Skip to content

build: disable rocm-smi-lib build (deprecated) #6852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gabrpham merged 4 commits into from
Aug 31, 2026
Merged

build: disable rocm-smi-lib build (deprecated) #6852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2c03b53
build: disable rocm-smi-lib build (deprecated)
marifamd Jul 24, 2026
5851fe1
Update post_hook_rocm_smi_lib to prevent failure of base build
gabrpham Aug 11, 2026
dabcf04
remove additional rocm_smi references from build procedures in pytorc…
gabrpham Aug 19, 2026
677f652
removed post_hook_rocm_smi_lib.cmake
gabrpham Aug 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions base/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,9 +79,10 @@ therock_cmake_subproject_declare(rocm_smi_lib
USE_DIST_AMDGPU_TARGETS
BACKGROUND_BUILD
CMAKE_ARGS
# See the post_hook, which needs to advertise install interface directories
# in this case.
"-DTHEROCK_HAS_BUNDLED_LIBDRM=${THEROCK_BUNDLED_LIBDRM}"
# rocm-smi-lib is deprecated in favor of AMD SMI; skip building it. The
# subproject honors this flag and configures to a no-op.
"-DROCM_SMI_DISABLE=True"
INTERFACE_LINK_DIRS
"lib"
INSTALL_RPATH_DIRS
Expand Down
18 changes: 0 additions & 18 deletions base/post_hook_rocm_smi_lib.cmake
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion build_tools/packaging/python/templates/rocm-sdk-core/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,6 @@ def import_dist_info():
"hipify-perl=rocm_sdk_core._cli:hipify_perl",
"rocm_agent_enumerator=rocm_sdk_core._cli:rocm_agent_enumerator",
"rocminfo=rocm_sdk_core._cli:rocm_info",
"rocm-smi=rocm_sdk_core._cli:rocm_smi",
"roccoremerge=rocm_sdk_core._cli:roccoremerge",
"rocgdb=rocm_sdk_core._cli:rocgdb",
"rocpd=rocm_sdk_core._cli:rocpd",
Expand Down
4 changes: 0 additions & 4 deletions build_tools/packaging/python/templates/rocm-sdk-core/src/rocm_sdk_core/_cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,6 @@ def rocm_info():
_exec("bin/rocminfo", expand_devel=False)


def rocm_smi():
_exec("bin/rocm-smi", expand_devel=False)


def roccoremerge():
_exec("bin/roccoremerge")

Expand Down
1 change: 0 additions & 1 deletion build_tools/packaging/python/templates/rocm/src/rocm_sdk/_dist_info.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,6 @@ def determine_target_family() -> str:
)
LibraryEntry("amd_comgr", "core", "libamd_comgr.so*", "amd_comgr*.dll")
LibraryEntry("rocm_kpack", "core", "librocm_kpack.so*", "rocm_kpack*.dll")
LibraryEntry("rocm_smi64", "core", "librocm_smi64.so*", "")
LibraryEntry("rocdecode", "core", "librocdecode.so*", "")
LibraryEntry("rocjpeg", "core", "librocjpeg.so*", "")
LibraryEntry("amd_smi", "core", "libamd_smi.so*", "")
Expand Down
1 change: 0 additions & 1 deletion build_tools/packaging/python/templates/rocm/src/rocm_sdk/tests/core_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
("amd-smi", [], "AMD-SMI", True),
("rocm_agent_enumerator", [], "", True),
("rocminfo", [], "", True),
("rocm-smi", [], "Management", True),
("hipify-perl", ["--help"], "USAGE:", True),
]

Expand Down
1 change: 0 additions & 1 deletion external-builds/pytorch/build_prod_wheels.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,6 @@
"hipdnn",
"rocm_sysdeps_liblzma",
"rocm-openblas",
"rocm_smi64",
# Linux only.
"rocprofiler-sdk", # Needed by torch since kineto uses rocprofiler-sdk.
"rocprofiler-sdk-roctx",
Expand Down
Loading