Repository navigation
[ROCm] Migrate SMI device queries from rocm_smi to amd_smi (v0.11.0) - #1139
Merged
i-chaochen merged 1 commit intoAug 27, 2026
Conversation
gulsumgudukbay
force-pushed
the
users/gulsumgudukbay/migrate-rocm-smi-to-amd-smi-v0.11.0
branch
6 times, most recently
from
August 27, 2026 02:19
b43f7be to
96c0969
Compare
Cherry-pick of #1113 (02298de) with SMI-only Bazel changes on this release branch. Unblocks JAX wheel builds when librocm_smi64 is absent from the ROCm SDK (ROCm/TheRock#6852).
gulsumgudukbay
force-pushed
the
users/gulsumgudukbay/migrate-rocm-smi-to-amd-smi-v0.11.0
branch
from
August 27, 2026 02:31
96c0969 to
2225114
Compare
Collaborator
|
do we need to merge these PRs? |
Author
yes please |
3 tasks done
gulsumgudukbay
deleted the
users/gulsumgudukbay/migrate-rocm-smi-to-amd-smi-v0.11.0
branch
August 27, 2026 16:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Minimal port of ROCm/xla#1113 (02298de) onto
rocm-jaxlib-v0.11.0. This is not a full cherry-pick: only the SMI migration lands, scoped to what this release branch needs to build oncelibrocm_smi64is absent from the SDK (ROCm/TheRock#6852).What changes (13 files):
third_party/gpus/rocm/BUILD.tpl: replaceamdsmi_libswithrocm_lib_import(name = "amdsmi", ...); leaverocm_smiand the rest of the release-branch template untouched.xla/stream_executor/rocm/BUILD: add:smialias (amd_smi from ROCm 7.13+, rocm_smi below),:smi_util, and wire pcie/xgmi deps; no unrelated release-branch BUILD churn.smi_util.{h,cc},smi_util_amd_smi.cc,smi_util_rocm_smi.cc; update pcie/xgmi callers and tests; deleterocm_smi_util.*.rocm_executor.cc: only the pcie/xgmi caller hunks from [WIP] [ROCm] Migrate SMI device queries from rocm_smi to amd_smi #1113 (~23 lines), not main's wider TF→ABSL status-macro refactor.Release-branch adaptations vs main #1113:
//xla/tsl/platform:status_macros(release branches lack@com_google_absl//absl/status:status_macros)..ccfiles useRETURN_IF_ERROR/ASSIGN_OR_RETURNfrom that header.Test plan
rocm-jaxlib-v0.11.0jax_rocm_pjrt_wheelbuild once [WIP] [ROCm] Migrate SMI device queries from rocm_smi to amd_smi #1113 merges to main and this lands on the matching JAX release branchBased on: #1113 (02298de)