Repository navigation
[math-libs] Enable rocPRIM benchmark builds - #4334
Merged
Merged
Conversation
Add -DBUILD_BENCHMARK=ON and amdsmi build dependency to the rocPRIM_tests subproject so that rocPRIM benchmark binaries are built alongside tests. Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
…able Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
lajagapp
marked this pull request as ready for review
April 20, 2026 13:47
lajagapp
requested review from
geomin12,
jayhawk-commits,
kiranzangam and
stanleytsang-amd
April 20, 2026 13:47
geomin12
reviewed
Apr 21, 2026
Contributor
Author
This build failure is caused by recent rocm-libraries commit ROCm/rocm-libraries#5512. Now I've created github-issue for it #4739. It wasn't caught by rocm-libraries CI because benchmarks aren't built in their pre-checkin workflow. Our PR is the first to actually compile rocPRIM benchmarks, which is why it is observed here. I've filed a fix upstream: ROCm/rocm-libraries#6662. And started trial run now - https://github.com/ROCm/TheRock/actions/runs/24775330791 |
Contributor
Author
|
Upstream fix is merged now, we need to wait for rocm-libraries submodule update with fix. |
geomin12
reviewed
Apr 23, 2026
geomin12
left a comment
geomin12
left a comment
Contributor
There was a problem hiding this comment.
let's wait for rocm-libraries bump. i would also appreciate review from rocprim folks if this makes sense
Contributor
Author
rocm-libraries submodule updated with fix. Rebased the PR now. |
geomin12
reviewed
Apr 29, 2026
stanleytsang-amd
approved these changes
May 27, 2026
This was referenced Jun 3, 2026
geomin12
pushed a commit
that referenced
this pull request
Jun 4, 2026
…lable (#5612) ## Summary - Guard `_rocprim_benchmark_enable` on `TARGET amdsmi` so the prim-isolated CI build (`-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_PRIM=ON`) no longer fails configure with `get_target_property() called with non-existent target "amdsmi"`. - Full SDK builds are unaffected — `amdsmi` is declared (via `THEROCK_ENABLE_CORE_AMDSMI`), so the target is present, and benchmarks build exactly as before. - Mirrors the existing precedent at `core/CMakeLists.txt:589` for `rocrtst`. ## Background #4334 added `amdsmi` to `rocPRIM_tests` `BUILD_DEPS` unconditionally for non-Windows, but `amdsmi` is only declared as a TheRock subproject when `THEROCK_ENABLE_CORE_AMDSMI` is ON. The prim-isolated CI group doesn't enable CORE, so `_therock_cmake_subproject_collect_build_deps` blows up before configure completes. This is breaking the rocm-libraries TheRock-pin bump in [ROCm/rocm-libraries#7979](ROCm/rocm-libraries#7979) (e.g. `Linux (rocthrust,rocprim,hipcub | gfx94X-dcgpu) / Build`). Related upstream tracking: #4651 (rocPRIM should also gracefully skip `find_package(amd_smi)` when not requested — once that lands, the `therock_rocprim_benchmark_deps.cmake` workaround can be dropped, but this guard is still the right shape regardless). ## Test plan - [ ] TheRock CI green on full SDK (benchmarks still built — confirm `benchmark_*` binaries under `dist/rocm/`) - [x] TheRock CI green on any prim-isolated job (configure no longer errors) - [ ] After merge, repoint rocm-libraries#7979's `therock-ref` to the merge SHA and re-run its failing build jobs
davidd-amd
pushed a commit
that referenced
this pull request
Jun 5, 2026
…lable (#5612) ## Summary - Guard `_rocprim_benchmark_enable` on `TARGET amdsmi` so the prim-isolated CI build (`-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_PRIM=ON`) no longer fails configure with `get_target_property() called with non-existent target "amdsmi"`. - Full SDK builds are unaffected — `amdsmi` is declared (via `THEROCK_ENABLE_CORE_AMDSMI`), so the target is present, and benchmarks build exactly as before. - Mirrors the existing precedent at `core/CMakeLists.txt:589` for `rocrtst`. ## Background #4334 added `amdsmi` to `rocPRIM_tests` `BUILD_DEPS` unconditionally for non-Windows, but `amdsmi` is only declared as a TheRock subproject when `THEROCK_ENABLE_CORE_AMDSMI` is ON. The prim-isolated CI group doesn't enable CORE, so `_therock_cmake_subproject_collect_build_deps` blows up before configure completes. This is breaking the rocm-libraries TheRock-pin bump in [ROCm/rocm-libraries#7979](ROCm/rocm-libraries#7979) (e.g. `Linux (rocthrust,rocprim,hipcub | gfx94X-dcgpu) / Build`). Related upstream tracking: #4651 (rocPRIM should also gracefully skip `find_package(amd_smi)` when not requested — once that lands, the `therock_rocprim_benchmark_deps.cmake` workaround can be dropped, but this guard is still the right shape regardless). ## Test plan - [ ] TheRock CI green on full SDK (benchmarks still built — confirm `benchmark_*` binaries under `dist/rocm/`) - [x] TheRock CI green on any prim-isolated job (configure no longer errors) - [ ] After merge, repoint rocm-libraries#7979's `therock-ref` to the merge SHA and re-run its failing build jobs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable building of rocPRIM benchmarks in TheRock's build system, with platform guards for Windows.
Changes
math-libs/CMakeLists.txt:-DBUILD_BENCHMARK=ONto therocPRIM_testssubproject CMake args (Linux)amdsmitoBUILD_DEPS(benchmarks link againstamd_smiviaprimbench.hpp)-DBUILD_BENCHMARK=OFF) sinceamdsmiis Linux-onlytherock_rocprim_benchmark_deps.cmakeviaCMAKE_INCLUDESto provide the missingfind_package(amd_smi)callcmake/therock_rocprim_benchmark_deps.cmake(new):find_package(amd_smi)inbenchmark/CMakeLists.txtartifact-prim.toml:bin/benchmark_*to the include listDetails
rocPRIM ships ~40 benchmarks under
rocm-libraries/projects/rocprim/benchmark/covering block, device, and warp-level primitives. These were not previously built becauseBUILD_BENCHMARKdefaults toOFF.The
CMAKE_INCLUDESworkaround is needed because upstream rocPRIM'sbenchmark/CMakeLists.txtlinks againstamd_smibut never callsfind_package(amd_smi), which only matters in non-system-install environments like TheRock. See #4651 for the upstream fix.