Repository navigation
[math-libs] Skip rocPRIM benchmark build when amdsmi target is unavailable - #5612
Merged
Merged
Conversation
…lable Commit 50b96d6 (#4334) added amdsmi to rocPRIM_tests BUILD_DEPS unconditionally for non-Windows. But amdsmi is only declared as a subproject when THEROCK_ENABLE_CORE_AMDSMI is ON, so the prim-isolated CI build (-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_PRIM=ON) fails at configure time: CMake Error at cmake/therock_subproject.cmake:1502 (get_target_property): get_target_property() called with non-existent target "amdsmi". Guard the benchmark enable on TARGET amdsmi, mirroring the existing pattern at core/CMakeLists.txt:589 for rocrtst. Full SDK builds are unaffected (amdsmi target is present, benchmarks build as before); prim-isolated builds now gracefully disable benchmarks instead of erroring out. Related: #4651 (upstream rocPRIM should also skip find_package(amd_smi) when not requested).
JonathanLichtnerAMD
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 3, 2026
Temporary commit to test the prim-isolated build fix from ROCm/TheRock#5612 (rocPRIM amdsmi guard) against rocm-libraries CI. To be replaced with the squash-merge SHA once #5612 lands.
1 task
geomin12
approved these changes
Jun 4, 2026
JonathanLichtnerAMD
added a commit
to ROCm/rocm-libraries
that referenced
this pull request
Jun 5, 2026
Replaces the temporary branch-tip pin with the squash-merge SHA on TheRock main, now that ROCm/TheRock#5612 (rocPRIM amdsmi guard) has landed.
davidd-amd
pushed a commit
that referenced
this pull request
Jun 5, 2026
…lable (#5612) ## Summary - Guard `_rocprim_benchmark_enable` on `TARGET amdsmi` so the prim-isolated CI build (`-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_PRIM=ON`) no longer fails configure with `get_target_property() called with non-existent target "amdsmi"`. - Full SDK builds are unaffected — `amdsmi` is declared (via `THEROCK_ENABLE_CORE_AMDSMI`), so the target is present, and benchmarks build exactly as before. - Mirrors the existing precedent at `core/CMakeLists.txt:589` for `rocrtst`. ## Background #4334 added `amdsmi` to `rocPRIM_tests` `BUILD_DEPS` unconditionally for non-Windows, but `amdsmi` is only declared as a TheRock subproject when `THEROCK_ENABLE_CORE_AMDSMI` is ON. The prim-isolated CI group doesn't enable CORE, so `_therock_cmake_subproject_collect_build_deps` blows up before configure completes. This is breaking the rocm-libraries TheRock-pin bump in [ROCm/rocm-libraries#7979](ROCm/rocm-libraries#7979) (e.g. `Linux (rocthrust,rocprim,hipcub | gfx94X-dcgpu) / Build`). Related upstream tracking: #4651 (rocPRIM should also gracefully skip `find_package(amd_smi)` when not requested — once that lands, the `therock_rocprim_benchmark_deps.cmake` workaround can be dropped, but this guard is still the right shape regardless). ## Test plan - [ ] TheRock CI green on full SDK (benchmarks still built — confirm `benchmark_*` binaries under `dist/rocm/`) - [x] TheRock CI green on any prim-isolated job (configure no longer errors) - [ ] After merge, repoint rocm-libraries#7979's `therock-ref` to the merge SHA and re-run its failing build jobs
10 of 14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_rocprim_benchmark_enableonTARGET amdsmiso the prim-isolated CI build (-DTHEROCK_ENABLE_ALL=OFF -DTHEROCK_ENABLE_PRIM=ON) no longer fails configure withget_target_property() called with non-existent target "amdsmi".amdsmiis declared (viaTHEROCK_ENABLE_CORE_AMDSMI), so the target is present, and benchmarks build exactly as before.core/CMakeLists.txt:589forrocrtst.Background
#4334 added
amdsmitorocPRIM_testsBUILD_DEPSunconditionally for non-Windows, butamdsmiis only declared as a TheRock subproject whenTHEROCK_ENABLE_CORE_AMDSMIis ON. The prim-isolated CI group doesn't enable CORE, so_therock_cmake_subproject_collect_build_depsblows up before configure completes.This is breaking the rocm-libraries TheRock-pin bump in ROCm/rocm-libraries#7979 (e.g.
Linux (rocthrust,rocprim,hipcub | gfx94X-dcgpu) / Build).Related upstream tracking: #4651 (rocPRIM should also gracefully skip
find_package(amd_smi)when not requested — once that lands, thetherock_rocprim_benchmark_deps.cmakeworkaround can be dropped, but this guard is still the right shape regardless).Test plan
benchmark_*binaries underdist/rocm/)therock-refto the merge SHA and re-run its failing build jobs