Repository navigation
Conversation
Commit 7692a35 ("feat(primbench): support an extra backend #5512") added an assert() call in format_eta() without including <cassert>. This breaks any consumer that compiles primbench.hpp without a transitive include of <cassert> from another header, such as the rocPRIM benchmark build in TheRock. Signed-off-by: Lenine Ajagappane <Lenine.Ajagappane@amd.com>
Contributor
Author
|
Similar change merged now, closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#include <cassert>toshared/primbench/primbench.hppassert()call at line 1506 (informat_eta()) was added in feat(primbench): support an extra backend #5512 without the corresponding include, causing a compile error:use of undeclared identifier 'assert'TheRock issue: ROCm/TheRock#4739
Test plan
BUILD_BENCHMARK=ON