[dockerfiles] Remove texinfo-tex from list of packages to install#3240
Conversation
lumachad
changed the title
|
@HereThereBeDragons Just so you're aware of this one. I'll flip it for a review once the CI results are clean. |
Fyi, pushing this will build a new Docker image. You would need another CI run in which you manually test with the new image, see https://github.com/ROCm/TheRock/tree/main/dockerfiles#working-on-the-dockerfiles-themselves. |
Right, I'm aware that some coordination is needed when the image gets updated. Let me go read the docs. It wasn't clear to me how to actually fetch the new sha. |
|
you can build a image on this branch using the build manylinux image action. then you need another pr where you just replace all the sha from the manylinux image with your new sha. should be multiple workflow files where you need to replace it |
Update sha: From: db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb To: 45b929e7edd4097f50b360ad718b25b597645d75dd11fccd592a4edc68fd786c See producing PR #3240
|
Validating the new image here: #3249. Hopefully that looks OK. |
Update sha: From: db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb To: 3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee See producing PR #3240
|
@HereThereBeDragons From looking at #3249, it seems CI agrees with the new image. Should we go for a real image after merging this one? edit: It isn't clear what the summary says. I don't see those Ubuntu failures or they're not related. |
|
we are running on the manylinux docker which is rhel/centos based. but as it is building etc. removing the texinfo-tex didnt cause any problems. |
The texinfo-tex package was required in order to build the rocgdb pdf documentation, but installation of the rocgdb pdf documentation was dropped. So drop the texinfo-tex package as well.
lumachad
force-pushed
the
users/lumachad/therock/general/texinfo-tex
branch
from
0851059 to
aae0144
Compare
|
@HereThereBeDragons Alright. If this change looks OK, I can do that process. |
Move to sha256:f8b279ec7b6d5c64d1e422a09e0a86e29fc5adb3a89c3e4d66af2f7bf72df23d. Reference image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:6e8242d347af7e0c43c82d5031a3ac67b669f24898ea8dc2f1d5b7e4798b66bd See producing PR #3240.
|
New PR to bump image to include these changes: #3306. |
Move to sha256:f8b279ec7b6d5c64d1e422a09e0a86e29fc5adb3a89c3e4d66af2f7bf72df23d. Reference image: ghcr.io/rocm/therock_build_manylinux_x86_64@sha256:6e8242d347af7e0c43c82d5031a3ac67b669f24898ea8dc2f1d5b7e4798b66bd See producing PR #3240.
Update sha: From: db2b63f938941dde2abc80b734e64b45b9995a282896d513a0f3525d4591d6cb To: 3494ea779c36b765da3ed55306db89704358b699a2d83835e81e9c67729104ee See producing PR #3240
Cherry-picked commits from ROCm/rocm-systems#3240: - Fix use-after-free in Runtime::DestroyAgents() cleanup ordering - rocrtst: Avoid double shutdown under ASAN
…, #3256, #3240, #3208 Cherry-picked commits: - PR #3256: 3 commits for IPC socket thread management and error handling - PR #3240: 1 commit for ASan use-after-free fix in system region cleanup - PRs #3407, #3208: Already included in previous cherry-picks These changes improve ASAN compatibility and fix memory management issues.
3 participants
The texinfo-tex package was required in order to build the rocgdb pdf documentation, but installation of the rocgdb pdf documentation was dropped.
So drop the texinfo-tex package as well.