[CI] Move ci path filtering funcs into separate file#3256
Conversation
HereThereBeDragons
requested review from
ScottTodd,
geomin12,
jayhawk-commits and
marbre
| from ci_path_filters import ( | ||
| get_git_modified_paths_since, | ||
| get_git_submodule_paths, | ||
| is_ci_run_required, | ||
| ) |
There was a problem hiding this comment.
@jayhawk-commits has work in progress at #3181 that I believe will allow rocm-libraries and rocm-systems to plug in their own logic here with code in e.g. https://github.com/ROCm/rocm-libraries/blob/develop/.github/scripts/therock_configure_ci.py
I think this refactoring is a net improvement but let's check if it aligns with those plans or if a slightly different approach would be more composable
There was a problem hiding this comment.
The refactoring in this PR would be useful for the pending work in #3188 where I am moving some shared configure functions useful to external repos into a shared configure module, and the super-repo specific functionality in another configure module. The work here overlaps with some of the functionality of those modules.
As far as #3181 goes, I think no changes are required for now. The changes would be in #3188 where I would make functions like _is_path_skippable work for external repos, by pulling in the skippable path list from the other repo through the work in #3181.
I think #3181 and #3256 can land simultaneously without issues. I'll modify #3188 after both land.
ScottTodd
left a comment
ScottTodd
left a comment
There was a problem hiding this comment.
LGTM % the comments about file / test naming
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
LGTM once Scott's naming comments are addressed. Eventually consider changing the one function name as well but beside that good to land.
…name better names for some functions.
…ci_path_filters.py -> configure_ci_path_filters.py
HereThereBeDragons
force-pushed
the
users/lpromber/move_ci_path_filtering
branch
from
7771d26 to
1dfc28a
Compare
Cherry-picked commit from ROCm/rocm-systems#3256: - rocr: IPC: Manage IPC socket thread lifetime
…, #3256, #3240, #3208 Cherry-picked commits: - PR #3256: 3 commits for IPC socket thread management and error handling - PR #3240: 1 commit for ASan use-after-free fix in system region cleanup - PRs #3407, #3208: Already included in previous cherry-picks These changes improve ASAN compatibility and fix memory management issues.
5 participants
Move all functions related to ci path filtering and determining based on this if the CI should be run or not into a separate file
configure_ci_path_filters.py.Aside from adjusting description, also gives better names to the following functions:
Part of CI weekly progress (big picture #1732 ) so that the new and old CI configurators can share those functions.