[release/7.11] [CI] Adjust Linux release for rockrel#3055
Conversation
…ve triggering jax workflow.
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
The changes to .github/workflows/build_native_linux_packages.yml need to go to main as well. I'd rather split it therefore to be able to apply the same patch to main as well as the release branch. JAX can be an additional, separate patch.
HereThereBeDragons
changed the title
|
removed the part about jax |
| python ./build_tools/fetch_artifacts.py \ | ||
| --run-id=${{ env.ARTIFACT_RUN_ID }} \ | ||
| --run-github-repo="ROCm/TheRock" \ | ||
| --run-github-repo=${{ inputs.repository || 'ROCm/TheRock' }} \ |
There was a problem hiding this comment.
Not sure about the mechanism behind when passing --run-github-repo. This probably needs a careful look.
There was a problem hiding this comment.
i will put it back to the hardcoded rocm/therock.
@ScottTodd probably knows better if something else is safe.
There was a problem hiding this comment.
I don't think this is going to work when glancing at
.
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
Workflow adjustment look correct but installing artifacts won't work as far as I see.
|
if it doesnt work then we need to have a closer look to what |
Adjust to make `.github/workflows/release_portable_linux_packages.yml` propagate all needed params to native packaging, so that it can be triggered from outside TheRock.
2 participants
Adjust to make
.github/workflows/release_portable_linux_packages.ymlpropagate all needed params to native packaging, so that it can be triggered from outside TheRock.