Skip to content

[release/7.11] [CI] Adjust Linux release for rockrel #3055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HereThereBeDragons merged 4 commits into from
Jan 23, 2026
Merged

[release/7.11] [CI] Adjust Linux release for rockrel #3055

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cbd830b
adjust build_native_linux_packages to run from outside the rock, remo…
HereThereBeDragons Jan 22, 2026
1da6b02
remove unneeded repository for native packging workflow dispatch
HereThereBeDragons Jan 23, 2026
3a699b5
change request + readd jax for easier cherrypick
HereThereBeDragons Jan 23, 2026
6697d6d
nit change request
HereThereBeDragons Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions .github/workflows/build_native_linux_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,12 @@ on:
description: The type of release to build ("dev", "nightly", or "prerelease"). All developer-triggered jobs should use "dev"!
type: string
default: "dev"
repository:
description: "Repository to checkout. Otherwise, defaults to `github.repository`."
type: string
Comment thread
HereThereBeDragons marked this conversation as resolved.
Outdated
ref:
description: "Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow."
type: string
Comment thread
HereThereBeDragons marked this conversation as resolved.

permissions:
id-token: write
Expand All @@ -78,10 +84,17 @@ jobs:
RELEASE_TYPE: ${{ inputs.release_type || '' }}
S3_BUCKET_NATIVE: "therock-${{ inputs.release_type }}-packages"
steps:
- uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
- uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
- name: "Checking out repository"
uses: actions/checkout@8e8c483db84b4bee98b60c0593521ed34d9990e8 # v6.0.1
with:
repository: ${{ inputs.repository || github.repository }}
ref: ${{ inputs.ref || '' }}

- name: Set up Python 3.12
Comment thread
HereThereBeDragons marked this conversation as resolved.
Outdated
uses: actions/setup-python@83679a892e2d95755f2dac6acb0bfd1e9ac5d548 # v6.1.0
with:
python-version: '3.12'

- name: Install Python requirements
run: |
pip install pyelftools boto3 jinja2
Expand All @@ -100,7 +113,7 @@ jobs:
echo "Fetching artifacts for build ${{ inputs.artifact_run_id }}"
python ./build_tools/fetch_artifacts.py \
--run-id=${{ env.ARTIFACT_RUN_ID }} \
--run-github-repo="ROCm/TheRock" \
--run-github-repo=${{ inputs.repository || 'ROCm/TheRock' }} \

@marbre marbre Jan 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about the mechanism behind when passing --run-github-repo. This probably needs a careful look.

@HereThereBeDragons HereThereBeDragons Jan 23, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i will put it back to the hardcoded rocm/therock.
@ScottTodd probably knows better if something else is safe.

@marbre marbre Jan 23, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is going to work when glancing at

TheRock/build_tools/github_actions/github_actions_utils.py

Line 461 in d81a594

def retrieve_bucket_info(
.

--artifact-group=${{ inputs.artifact_group }} \
--output-dir=${{ env.ARTIFACTS_DIR }}

Expand Down
23 changes: 2 additions & 21 deletions .github/workflows/release_portable_linux_packages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -329,27 +329,6 @@ jobs:
"ref": "${{ inputs.ref || '' }}"
}

- name: URL-encode .tar URL
# TODO: Enable JAX wheels for prereleases
if: ${{ env.RELEASE_TYPE != 'prerelease' }}
id: url-encode-tar
run: python -c "from urllib.parse import quote; print('tar_url=${{ needs.setup_metadata.outputs.cloudfront_base_url }}/tarball/' + quote('${{ env.FILE_NAME }}'))" >> ${GITHUB_OUTPUT}

- name: Trigger build JAX wheels
# TODO: Enable JAX wheels for prereleases
if: ${{ env.RELEASE_TYPE != 'prerelease' && github.repository_owner == 'ROCm' }}
uses: benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc # v1.2.4
with:
workflow: build_linux_jax_wheels.yml
inputs: |
{ "amdgpu_family": "${{ matrix.target_bundle.amdgpu_family }}",
"python_version": "3.12",
"release_type": "${{ env.RELEASE_TYPE }}",
"s3_subdir": "${{ env.S3_STAGING_SUBDIR }}",
"rocm_version": "${{ needs.setup_metadata.outputs.version }}",
"tar_url": "${{ steps.url-encode-tar.outputs.tar_url }}"
}

- name: Trigger build native rpm package
if: ${{ github.repository_owner == 'ROCm' }}
uses: benc-uk/workflow-dispatch@e2e5e9a103e331dad343f381a29e654aea3cf8fc # v1.2.4
Expand All @@ -360,6 +339,7 @@ jobs:
"rocm_version": "${{ needs.setup_metadata.outputs.rpm_version }}",
"release_type": "${{ env.RELEASE_TYPE }}",
"artifact_run_id": "${{ github.run_id }}",
"ref": "${{ inputs.ref || '' }}",
"native_package_type": "rpm"
}

Expand All @@ -373,6 +353,7 @@ jobs:
"rocm_version": "${{ needs.setup_metadata.outputs.deb_version }}",
"release_type": "${{ env.RELEASE_TYPE }}",
"artifact_run_id": "${{ github.run_id }}",
"ref": "${{ inputs.ref || '' }}",
"native_package_type": "deb"
}

Expand Down
Loading