Add native linux packaging#20
Conversation
|
let me know if we just should add it only to 7.11 and not to For TheRock, the needed PR for 7.11 is: ROCm/TheRock#3055 |
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
First comments, needs a more careful review side-by-side to the upstream workflow.
| ref: | ||
| description: "Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow." | ||
| type: string | ||
| default: main |
There was a problem hiding this comment.
This will break if triggered from a release branch and if someone forgets to set this. Furthermore, is does not match the description.
| default: main |
There was a problem hiding this comment.
i can adjust the description. so far we have added this default always to name the release branch. i thought it would be nice to just search for main and replace all for the new release?
what would you prefer? remove? or adjust description?
There was a problem hiding this comment.
If you want to set a default, default: '' should work but pinning to main is probably not what we want here.
| artifact_group: ${{ inputs.artifact_group }} | ||
| release_type: ${{ inputs.release_type }} | ||
| rocm_version: ${{ inputs.rocm_version }} | ||
| artifact_run_id: ${{ github.run_id }} |
There was a problem hiding this comment.
There is actually a chance that we override packages as this uses the run_id in rockrel which is unique here but we could have had the same in TheRock. Needs to be addressed in a follow up.
marbre
left a comment
marbre
left a comment
There was a problem hiding this comment.
LG to land as is and to allow further testing. Might need follow up changes upstream though.
First version to be able to build native linux packaging from rockrel. While the name is build_native.. it has the same pattern as the release_.. we already have here: just invoking via workflow-dispatch the equivalent workflow in TheRock
This PR is raised to cherry pick #20 from main to release branch and also to pin build_native_linux_packages to release branch 7.11. This will help build prereleases for 7.11 --------- Co-authored-by: Laura Promberger <lpromber@amd.com> Co-authored-by: Aravind Ravikumar <arravikum@amd.com> Co-authored-by: nunnikri <71024015+nunnikri@users.noreply.github.com>
2 participants
First version to be able to build native linux packaging from rockrel.
While the name is build_native.. it has the same pattern as the release_.. we already have here: just invoking via workflow-dispatch the equivalent workflow in TheRock