Skip to content

Specify repository and ref to checkout#1557

Merged
marbre merged 2 commits into
mainfrom
users/marbre/therock-releases
Sep 23, 2025
Merged

Specify repository and ref to checkout#1557
marbre merged 2 commits into
mainfrom
users/marbre/therock-releases

Conversation

@marbre
Copy link
Copy Markdown
Member

@marbre marbre commented Sep 22, 2025

These changes enable to make use of the workflows as reusable workflows.

These changes enable to make use of the workflows as reusable workflows.
@marbre
Copy link
Copy Markdown
Member Author

marbre commented Sep 22, 2025

I'll post the summaries of a full dev build I triggered + the PyTorch build once it finished.

Comment on lines +46 to +48
ref:
description: "Branch, tag or SHA to checkout. Otherwise, uses the default branch."
type: string
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a little mind-bending. If you omit repository and ref but trigger a release from e.g. users/someone/test-branch, that will checkout the users/someone/test-branch in the workflow run, not main (the "default branch").

Maybe instead of "default branch" say "current branch" or "workflow trigger branch"? Or quote https://github.com/actions/checkout?tab=readme-ov-file#usage

    # The branch, tag or SHA to checkout. When checking out the repository that
    # triggered a workflow, this defaults to the reference or SHA for that event.
    # Otherwise, uses the default branch.
    ref: ''

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, makes sense to just copy what actions/checkout has here. Good point!

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rephrased to

"Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow."

Comment thread .github/workflows/build_portable_linux_pytorch_wheels.yml
Comment thread .github/workflows/release_portable_linux_packages.yml
Comment thread .github/workflows/test_pytorch_wheels.yml
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I only considered moving over Linux and we might do Windows in a follow up. But I will at the absolute file an issue. Thanks for bringing Windows back to my attention!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even if we don't use the workflows in that way on Windows yet, I'd still like to keep the same structure while we're making these changes, so they don't get too far out of sync.

These two issues stemmed from only updating Linux during initial work:

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fully agree! If this goes through, I'd like @HereThereBeDragons do jump onto the Windows workflows to free up some time on my side for other work.

@marbre marbre requested a review from ScottTodd September 22, 2025 22:21
@marbre
Copy link
Copy Markdown
Member Author

marbre commented Sep 23, 2025

The workflows

passed the expected stages.

@marbre marbre marked this pull request as ready for review September 23, 2025 11:15
@marbre marbre merged commit 240f6ed into main Sep 23, 2025
36 of 39 checks passed
@marbre marbre deleted the users/marbre/therock-releases branch September 23, 2025 11:16
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Sep 23, 2025
HereThereBeDragons added a commit that referenced this pull request Sep 23, 2025
Equivalent to PR #1557, these changes enable to make
use of the workflows as reusable workflows for the
windows ci.
HereThereBeDragons added a commit that referenced this pull request Sep 23, 2025
Equivalent to PR #1557, these changes enable to make use of the
workflows as reusable workflows for the windows ci.
@ScottTodd ScottTodd mentioned this pull request Dec 2, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants