Specify repository and ref to checkout#1557
Conversation
These changes enable to make use of the workflows as reusable workflows.
|
I'll post the summaries of a full dev build I triggered + the PyTorch build once it finished. |
| ref: | ||
| description: "Branch, tag or SHA to checkout. Otherwise, uses the default branch." | ||
| type: string |
There was a problem hiding this comment.
This is a little mind-bending. If you omit repository and ref but trigger a release from e.g. users/someone/test-branch, that will checkout the users/someone/test-branch in the workflow run, not main (the "default branch").
Maybe instead of "default branch" say "current branch" or "workflow trigger branch"? Or quote https://github.com/actions/checkout?tab=readme-ov-file#usage
# The branch, tag or SHA to checkout. When checking out the repository that
# triggered a workflow, this defaults to the reference or SHA for that event.
# Otherwise, uses the default branch.
ref: ''There was a problem hiding this comment.
Yeah, makes sense to just copy what actions/checkout has here. Good point!
There was a problem hiding this comment.
Rephrased to
"Branch, tag or SHA to checkout. Defaults to the reference or SHA that triggered the workflow."
There was a problem hiding this comment.
Please also update the Windows files:
- https://github.com/ROCm/TheRock/blob/main/.github/workflows/build_windows_pytorch_wheels.yml
- https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_windows_packages.yml
- https://github.com/ROCm/TheRock/blob/main/.github/workflows/release_windows_pytorch_wheels.yml
There was a problem hiding this comment.
For now I only considered moving over Linux and we might do Windows in a follow up. But I will at the absolute file an issue. Thanks for bringing Windows back to my attention!
There was a problem hiding this comment.
Even if we don't use the workflows in that way on Windows yet, I'd still like to keep the same structure while we're making these changes, so they don't get too far out of sync.
These two issues stemmed from only updating Linux during initial work:
There was a problem hiding this comment.
I fully agree! If this goes through, I'd like @HereThereBeDragons do jump onto the Windows workflows to free up some time on my side for other work.
|
The workflows passed the expected stages. |
Equivalent to PR #1557, these changes enable to make use of the workflows as reusable workflows for the windows ci.
Equivalent to PR #1557, these changes enable to make use of the workflows as reusable workflows for the windows ci.
These changes enable to make use of the workflows as reusable workflows.