Use cloudfront_staging_url for Windows pytorch testing workflow.#1469
Conversation
marbre
left a comment
There was a problem hiding this comment.
Those are easy mistakes to make. We could
- Rename the
cloudfront_urlinput to carry more meaning about what it represents, likepackage_index_urlorstaging_package_index_url- Bring up runners for more GPUs or change the default workflow_dispatch GPU type to one we have test runners for
Agree with both suggestions. Especially the renaming is a low hanging fruit.
|
The change looks good. I ran the workflow with the changes on both the Archs gfx1151(We have runners for this) and gfx110(We dont have runners). Unfortunately missed the test step on my run for for gfx1151 below, as builds were failing for gfx1151 and did not proceed to the test step. Run on gfx1151: https://github.com/ROCm/TheRock/actions/runs/17590905752 |
…#1437) ## Motivation Fixes #1040, enabling aotriton for flash attention in pytorch (if it works). This is expected to improve performance in workloads like ComfyUI image generation by upwards of 60% (e.g. 12.6 it/s to 20.0 it/s). ## Technical Details Follow-up to #1432 and depends on pytorch/pytorch#162330. Note that support is experimental for some GPUs like gfx1100, so the `TORCH_ROCM_AOTRITON_ENABLE_EXPERIMENTAL=1` environment variable may be needed to try aotriton on those systems. ## Test Plan Trigger either https://github.com/ROCm/TheRock/actions/workflows/build_windows_pytorch_wheels.yml or https://github.com/ROCm/TheRock/actions/workflows/release_windows_pytorch_wheels.yml across the matrix of GPU families once that PyTorch PR is merged. We're still going to need automated tests and documentation for this. I'd like numerics tests running somewhere and documentation that shows how to check which pytorch features are enabled in the wheels that a user installs. ## Test Result Test runs: * https://github.com/ROCm/TheRock/actions/runs/17660396787 using this branch and `7.0.0rc20250908` for gfx110X-dgpu * ~~https://github.com/ROCm/TheRock/actions/runs/17660456285 using the branch and `7.0.0rc20250908` for gfx1151~~ * https://github.com/ROCm/TheRock/actions/runs/17662170140 using the branch and `7.0.0rc20250908` for gfx1151 * Tests not running should be fixed with #1469 (may need to retrigger to pick up fixes for flaky checkouts) ## Submission Checklist - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests.
|
## Motivation Following up on some ideas from #1469 to make workflows easier to use. ## Details * Set Windows workflow defaults to all gfx1151 (which we have test machines for). Linux defaults to gfx94X-dcgpu * Add some descriptions to workflow inputs * Rename cloudfront_url to package_index_url (in one place, others may want to change too) * Pack job names with more information ## Test Plan * copy_release.yml: https://github.com/ROCm/TheRock/actions/runs/17686001057 * I have **not** tested running the other workflows. Could do that on request (or revert this if it breaks workflows)
Motivation
Follow-up to #1110 and #1382. Progress on #1072.
This test run https://github.com/ROCm/TheRock/actions/runs/17662170140/job/50199734639#step:6:37 failed with
Technical Details
The build job only uploaded to v2-staging, so the test job should download from v2-staging, not v2.
The change here was made on Linux but was overlooked during the porting to Windows:
TheRock/.github/workflows/build_portable_linux_pytorch_wheels.yml
Lines 219 to 227 in eb05061
The https://github.com/ROCm/TheRock/actions/runs/17585233778 test run mentioned at #1382 (comment) did not run any tests and did not exercise this code because we only have gfx1151 runners and that used gfx110X-dgpu.
Those are easy mistakes to make. We could
cloudfront_urlinput to carry more meaning about what it represents, likepackage_index_urlorstaging_package_index_urlTest Plan
Untested.
Test Result
Nope.
Submission Checklist