Skip to content

Set SG_STAGING_SUBDIR in Windows release workflow.#1513

Merged
ScottTodd merged 1 commit into
ROCm:mainfrom
ScottTodd:windows-staging-fix
Sep 17, 2025
Merged

Set SG_STAGING_SUBDIR in Windows release workflow.#1513
ScottTodd merged 1 commit into
ROCm:mainfrom
ScottTodd:windows-staging-fix

Conversation

@ScottTodd
Copy link
Copy Markdown
Member

Progress on #1072. More follow-up to #1382 for missed plumbing due to workflows being copy/pasted instead of reusing the same scripts.

This workflow run failed: https://github.com/ROCm/TheRock/actions/runs/17788093970/job/50562946451#step:6:35, since it was looking outside of the staging subdirectory:

++ Exec [C:\runner\_work\TheRock\TheRock]$ 'C:\runner\_work\TheRock\TheRock\.venv\Scripts\python.exe' -m pip install --index-url=https://rocm.nightlies.amd.com/gfx1151 torch==2.10.0a0+rocm7.0.0rc20250917
Looking in indexes: https://rocm.nightlies.amd.com/gfx1151
ERROR: Could not find a version that satisfies the requirement torch==2.10.0a0+rocm7.0.0rc20250917 (from versions: none)

The workflow that triggered it had this variable unset, so it appended empty string to the base URL: https://github.com/ROCm/TheRock/actions/runs/17786272473/job/50554458282#step:6:5

  echo "cloudfront_url=${cloudfront_base_url}/v2" >> $GITHUB_OUTPUT
  echo "cloudfront_staging_url=${cloudfront_base_url}/" >> $GITHUB_OUTPUT

Untested.

Copy link
Copy Markdown
Contributor

@araravik-psd araravik-psd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ScottTodd ScottTodd merged commit 77c3f0a into ROCm:main Sep 17, 2025
5 checks passed
@ScottTodd ScottTodd deleted the windows-staging-fix branch September 17, 2025 15:41
@github-project-automation github-project-automation Bot moved this from TODO to Done in TheRock Triage Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants