New client host code#604
Merged
Merged
Conversation
- It runs a given problem - Verification works - Logging is almost there. - Timing code is stubbed out.
- TestData can now glob a directory. - TestData can now get a directory from an environment variable. - RunGEMMKernel_test now runs each library with each contraction.
Functional: - Repetition parameters - Basic timing - Result verification
- Common code for writing CSV data - Common code for extracting common pieces of information from the problem/solution
It's usable separately. Also this doesn't propagate the include dependency on rocm_smi.h .
Contributor
Author
|
Are there any other incoming PRs? This is getting ridiculous. I'm trying to get my changes in as soon as possible. |
zaliu
approved these changes
Aug 8, 2019
Contributor
There was a problem hiding this comment.
LGTM
With Tensile PR#604 and rocBLAS PR#639 (tweaked slightly), rocBLAS build succeeded on both Ubuntu and CentOS 7.6; rocblas-test passed on both also.
Please make matching changes to rocBLAS PR#639, then merge Tensile PR#604 then rocBLAS PR#639 in rapid succession to minimize rocBLAS CI breakage. Thanks.
p.s. It would be great if you would squash-merge this one.
amdkila
approved these changes
Aug 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of changes
.csvfiles which are compatible with the rest of the Python scripts.0_Build 1_BenchmarkProblems 2_BenchmarkData 3_LibraryLogic) when running the main Tensile scriptReorganized files
lib/clientis moved toTensile/Source/clientlib/testsis moved toHostLibraryTestslib/is moved toTensile/Source/libTensile/cmakeUser changes
Your compiler should be set to
hccwhen invokingcmake:Note the workaround (ROCm/hcc#1211):
Until the fix is available in
hccavailable throughapt, you will need to patch/opt/rocm/lib/cmake/hcc/hcc-config.cmakeon your machines in order to build Tensile (and rocBLAS once it's integrated). The dockerfile applies this automatically for CI, and there is a script to do this checked in: