Skip to content

Dont make the imported hsa-runtime64 target global#1211

Merged
scchan merged 1 commit into
clang_tot_upgradefrom
hsa-global
Jul 17, 2019
Merged

Dont make the imported hsa-runtime64 target global#1211
scchan merged 1 commit into
clang_tot_upgradefrom
hsa-global

Conversation

@pfultz2
Copy link
Copy Markdown
Contributor

@pfultz2 pfultz2 commented Jul 16, 2019

This causes problems if find_package(hcc) gets called twice.

@david-salinas david-salinas self-requested a review July 17, 2019 14:49
Copy link
Copy Markdown
Collaborator

@david-salinas david-salinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scchan scchan merged commit b46d291 into clang_tot_upgrade Jul 17, 2019
@scchan scchan deleted the hsa-global branch November 26, 2019 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants