Skip to content

Updating CMake to support changes in Tensile#639

Merged
sdquiring merged 7 commits into
ROCm:developfrom
sdquiring:develop
Aug 8, 2019
Merged

Updating CMake to support changes in Tensile#639
sdquiring merged 7 commits into
ROCm:developfrom
sdquiring:develop

Conversation

@sdquiring
Copy link
Copy Markdown
Contributor

Tensile PR 604: ROCm/Tensile#604

@sdquiring sdquiring requested review from amcamd and zaliu August 7, 2019 01:49
@sdquiring sdquiring requested a review from leekillough as a code owner August 7, 2019 01:49
Copy link
Copy Markdown
Contributor

@zaliu zaliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to include rocm_smi64 and zlib1g-dev (zlib-devel for CentOS and Fedora) in the list of packages to install in install.sh. Thanks.

Copy link
Copy Markdown
Contributor

@zaliu zaliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdquiring sdquiring merged commit 3dc3d65 into ROCm:develop Aug 8, 2019
mlse-lib-jenkins pushed a commit that referenced this pull request Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants