改进渠道管理功能（优先级提示、定时测试优化、参数修复）

[QLHazyCoder]

本 PR 包含三个针对渠道管理的改进：

1. feat: 为渠道优先级和权重添加提示图标

   • 提升用户体验，让优先级和权重配置更直观

2. refactor: 优化定时测试逻辑

   • 跳过已关闭自动禁用的渠道
   • 减少不必要的测试开销

3. fix: 修复 ShouldDisableChannel 参数错误

   • 将错误的 ChannelId 参数改为正确的 ChannelType
   • 修复潜在的逻辑错误

Summary by CodeRabbit

• New Features

  • Added help tooltips with icons to the priority and weight fields in the Edit Channel modal for clearer guidance.

• Refactor

  • Updated auto-disable behavior to determine eligibility based on channel type, improving consistency in when channels are automatically disabled.

• Tests

  • Adjusted tests to skip channels without auto-ban and align with the updated disable conditions.

[coderabbitai]

Walkthrough

Updates tests to skip non-auto-ban channels, adjusts relay logic to determine disable-eligibility by channelType instead of channelId, and enhances the EditChannelModal UI with tooltips and an icon explaining priority and weight.

Changes

Cohort / File(s)	Summary
Controller tests controller/channel-test.go	Early-return in test loop for channels with GetAutoBan() == false; downstream disable condition simplified to rely on the prior filter; error handling call sites updated accordingly.
Relay disable flow controller/relay.go, service/...	Disable eligibility now uses channelType: service signature changed from ShouldDisableChannel(channelId, err) to ShouldDisableChannel(channelType, err); async DisableChannel trigger unchanged.
Web UI: EditChannelModal tooltips web/src/components/table/channels/modals/EditChannelModal.jsx	Added Tooltip and IconHelpCircle imports; labels for priority and weight now wrapped with a tooltip explaining semantics; no data or validation changes.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor Client
  participant Controller as Controller (relay.go)
  participant Service as Service (ShouldDisableChannel)
  participant Worker as gopool worker
  participant Store as ChannelStore

  Client->>Controller: Relay request
  Controller->>Service: ShouldDisableChannel(channelType, err)
  alt eligible to disable
    Controller->>Worker: async DisableChannel(channelId)
    Worker->>Store: DisableChannel(channelId)
    Store-->>Worker: result
    Worker-->>Controller: (async completes)
  else not eligible
    Controller-->>Client: proceed without disable
  end
  note over Controller,Service: Eligibility now keyed by channelType (was channelId)

  %% Styling notes (color is supplemental; labels carry meaning)
  rect rgba(230, 240, 255, 0.6)
  note over Controller: Changed interaction
  end

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• add submodel.ai #1915 — Introduces new ChannelType wiring; aligns with switching disable eligibility to channelType.
• chore: opt video channel and platform #1416 — Centralizes platform inference on channel type; closely related to this PR’s type-based relay/disable logic.
• fix: update channel.go fix #1641 #1647 — Adds AutoBan guards in disable paths; related to this PR’s early AutoBan filtering in tests.

Suggested reviewers

• creamlike1024
• seefs001

Poem

I thump my paw: types lead the way,
From IDs to kinds, we hop and sway.
Tooltips bloom where labels stood,
Tests now skip what never would.
Burrow secure, channels in line—
Auto-ban guards, all by design. 🥕🐇

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check	✅ Passed	The title succinctly describes the three targeted improvements—priority hints, scheduled test optimization, and parameter correction—directly matching the PR objectives without introducing unrelated details or vague phrasing.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aa35d8d and 4273892.

📒 Files selected for processing (3)

• controller/channel-test.go (2 hunks)
• controller/relay.go (1 hunks)
• web/src/components/table/channels/modals/EditChannelModal.jsx (3 hunks)

🧰 Additional context used

🧬 Code graph analysis (1)

controller/relay.go (1)

service/channel.go (1)

• ShouldDisableChannel (47-99)

🔇 Additional comments (4)

controller/channel-test.go (2)

562-565: Good optimization: early exit for non-auto-ban channels.

The added guard correctly skips channels with auto-ban disabled before processing, reducing unnecessary test overhead. This aligns with the PR objective and improves efficiency.

---

589-591: Correctly removed redundant check after early filtering.

The channel.GetAutoBan() check is no longer needed here because channels with auto-ban disabled are now filtered at the start of the loop (lines 562-565). The updated comment clearly documents this change.

controller/relay.go (1)

287-287: Critical fix: corrected parameter from channelId to channelType.

This is an important bug fix. The ShouldDisableChannel function expects channelType (a channel type constant like ChannelTypeGemini) as shown in the service/channel.go snippet, not channelId (a unique identifier). Passing channelId would have broken type-specific disable logic, such as the switch statement at line 60-64 in service/channel.go that checks for specific channel types.

Based on code from service/channel.go showing the correct function signature and type-specific switch logic.

web/src/components/table/channels/modals/EditChannelModal.jsx (1)

51-51: Verify IconHelpCircle export
Ensure IconHelpCircle is actually exported by @douyinfe/semi-icons (e.g., inspect node_modules/@douyinfe/semi-icons/index.* or run npm explore @douyinfe/semi-icons -- grep -R "IconHelpCircle" -n .). If the name differs, update to the correct export (e.g., IconInfoCircle or IconQuestionCircle).

[coderabbitai]

⚠️ Potential issue | 🟡 Minor

Add i18n support for tooltip content.

The tooltip content is hardcoded in Chinese without using the t() translation function, which is inconsistent with the rest of the file and breaks internationalization support.

Apply this diff to add i18n support:

                          label={
                            <span>
                              {t('渠道优先级')}
-                              <Tooltip content='优先级决定渠道选择顺序。数值越高越优先,重试时依次降低优先级(retry=0选最高组)'>
+                              <Tooltip content={t('优先级决定渠道选择顺序。数值越高越优先,重试时依次降低优先级(retry=0选最高组)')}>
                                <IconHelpCircle className='text-gray-400 cursor-help' style={{ marginLeft: 4 }} />
                              </Tooltip>
                            </span>
                          }

                          label={
                            <span>
                              {t('渠道权重')}
-                              <Tooltip content='权重决定同优先级内的流量分配。数值越高流量越多,weight=0也会分配流量(实际权重+10)'>
+                              <Tooltip content={t('权重决定同优先级内的流量分配。数值越高流量越多,weight=0也会分配流量(实际权重+10)')}>
                                <IconHelpCircle className='text-gray-400 cursor-help' style={{ marginLeft: 4 }} />
                              </Tooltip>
                            </span>
                          }

Also applies to: 2413-2420

🤖 Prompt for AI Agents

In web/src/components/table/channels/modals/EditChannelModal.jsx around lines
2394-2401 and 2413-2420, the Tooltip content is hardcoded in Chinese; replace
the literal Chinese strings with calls to the translation function t() (e.g.
t('渠道优先级说明') or an appropriate i18n key) so the tooltip text is
internationalized, ensuring the Tooltip's content prop receives the translated
string and updating/adding the corresponding translation entries for the key(s)
used.