add submodel.ai - #1915
Merged
Merged
Conversation
# Conflicts: # common/api_type.go # constant/api_type.go # constant/channel.go # relay/relay_adaptor.go # web/src/constants/channel.constants.js
# Conflicts: # relay/relay_adaptor.go
将连接延迟关闭逻辑调整到协程中执行,防止在完全接收到所有数据前提前关闭
- Création du fichier de traduction `fr.json` en se basant sur `en.json`. - Mise à jour de la configuration i18n pour inclure la langue française. - Modification du sélecteur de langue pour afficher l'option "Français" avec le drapeau correspondant.
- Création du fichier `README.fr.md` en se basant sur `README.en.md`.
Contributor
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
constant/api_type.go (1)
34-36: Add an explicit count alias to prevent future regressions.Define a clear alias so callers don’t accidentally use a non‑sentinel as the bound.
package constant const ( @@ - APITypeSubmodel - APITypeDummy // this one is only for count, do not add any channel after this + APITypeSubmodel + APITypeDummy // this one is only for count, do not add any channel after this ) + +// Use APITypeCount as the canonical upper bound in loops/arrays. +const APITypeCount = APITypeDummy
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
constant/api_type.go(1 hunks)
🔇 Additional comments (2)
constant/api_type.go (2)
34-36: Correct sentinel ordering — LGTM.Submodel is placed before Dummy, and Dummy remains the terminal “count” sentinel. This resolves the earlier blocker about not appending after Dummy and keeps prior iota values stable.
34-36: No remaining sentinel-bound usages of APITypeMoonshot
Ripgrep confirms no loops, array lengths, or casts use APITypeMoonshot as an upper bound; existing case clauses are valid.
seefs001
self-requested a review
September 29, 2025 13:51
seefs001
approved these changes
Sep 29, 2025
This was referenced Sep 29, 2025
Merged
Merged
This was referenced Oct 15, 2025
Closed
Merged
This was referenced Jan 4, 2026
Closed
Merged
This was referenced Feb 21, 2026
3 tasks
This was referenced Apr 14, 2026
x22x22
pushed a commit
to x22x22/new-api
that referenced
this pull request
Apr 24, 2026
add submodel.ai
This was referenced Apr 28, 2026
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit
New Features
Style