fix : fix submodel adapter - #1919
Conversation
|
Caution Review failedThe pull request is closed. WalkthroughIntroduces a new Adaptor method ConvertGeminiRequest that returns a not-supported error and modifies GetRequestURL to reference info.ChannelBaseUrl instead of info.BaseUrl. Both changes are confined to relay/channel/submodel/adaptor.go. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Client
participant Adaptor
note over Client,Adaptor: Gemini request conversion flow (new method)
Client->>Adaptor: ConvertGeminiRequest(ctx, info, geminiReq)
Adaptor-->>Client: error "not supported"
note over Adaptor: Endpoint not implemented
sequenceDiagram
autonumber
actor Caller
participant Adaptor
participant RelayInfo as RelayInfo (info)
note over Caller,Adaptor: Request URL resolution (modified)
Caller->>Adaptor: GetRequestURL(info)
Adaptor->>RelayInfo: read ChannelBaseUrl
Adaptor-->>Caller: URL built from info.ChannelBaseUrl
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
✨ Finishing touches
🧪 Generate unit tests
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
fix : fix submodel adapter
Summary by CodeRabbit
Bug Fixes
Chores