Skip to content

Prepare 0.45.0 release#11169

Merged
mtreinish merged 41 commits into
Qiskit:stable/0.45from
ElePT:prepare-0.45
Nov 3, 2023
Merged

Prepare 0.45.0 release#11169
mtreinish merged 41 commits into
Qiskit:stable/0.45from
ElePT:prepare-0.45

Conversation

@ElePT
Copy link
Copy Markdown
Contributor

@ElePT ElePT commented Nov 1, 2023

Summary

This commit prepares the 0.45.0 release, this involves 3 steps:

  • changing all the version numbers to 0.45.0 from 0.45.0rc1
  • updating the release notes to prepare them for publishing
  • removing release notes from 0.45 that were back-ported to 0.25

As we did in 0.25, we're using a pre-release feature in reno to add subsections to the release notes. Subsections are added to the features, deprecations, and upgrade sections for:

  • transpiler
  • algorithms
  • circuits
  • quantum_info
  • pulse
  • providers
  • primitives
  • visualization
  • synthesis
  • misc
  • qasm

I have also added the following sections:

  • qpy

Details and comments

TODO:

  • Add missing changelog tags
  • Add subsections config
  • Add sections to release notes
  • Add prelude
  • Change all the version numbers to 0.45.0 from 0.45.0rc1

Missing PRs tagged for 0.45:

@ElePT ElePT added this to the 0.45.0 milestone Nov 1, 2023
@mtreinish mtreinish added priority: high Changelog: None Do not include in the GitHub Release changelog. labels Nov 1, 2023
Comment thread releasenotes/notes/0.45/dag-appenders-check-84d4ef20c1e20fd0.yaml Outdated
Comment thread releasenotes/notes/prepare-0.45-50118e5e6d110302.yaml Outdated
Comment thread releasenotes/notes/vf2-threading-b778a36de5b8832a.yaml Outdated
Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick notes, I haven't finished my detailed review yet. But figured in the interest of time I'd push what I had so far before stepping away for a little bit.

Comment thread releasenotes/notes/prepare-0.45-50118e5e6d110302.yaml Outdated
Comment thread releasenotes/notes/0.45/add-annotated-operations-de35a0d8d98eec23.yaml Outdated
Comment thread releasenotes/notes/0.45/add-passmanager-module-3ae30cff52cb83f1.yaml Outdated
Comment thread releasenotes/config.yaml Outdated
@ElePT ElePT added the on hold Can not fix yet label Nov 2, 2023
@ElePT ElePT marked this pull request as ready for review November 2, 2023 19:54
@ElePT ElePT requested a review from a team as a code owner November 2, 2023 19:54
@qiskit-bot
Copy link
Copy Markdown
Collaborator

One or more of the the following people are requested to review this:

Comment thread releasenotes/config.yaml
Comment on lines +7 to +11
- [features_algorithms, Algorithms Features]
- [features_circuits, Circuits Features]
- [features_primitives, Primitives Features]
- [features_providers, Providers Features]
- [features_pulse, Pulse Features]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should all be marked as subsections. From https://docs.openstack.org/reno/latest/user/usage.html

You can optionally include a number from 1 to 3 at the end of the list to mark the entry as a subsection. By default, each section has the number 1, which represents a top-level section. Use 2 and 3 for subsections and subsubsections. For example, ['features', 'New Features', 1], ['features_command_line', 'Command Line', 2], and ['features_command_line_ios', 'iOS', 3]. The order of this option matters; define subsections right after their ancestor sections.

Copy link
Copy Markdown
Contributor Author

@ElePT ElePT Nov 2, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how I originally tried to implement the subsections, but I kept getting docs build failures like this one saying CRITICAL: Title level inconsistent:, and this is the only fix I could find that worked. If you have any suggestions on how I could address those without removing the "2", please let me know.

Comment thread releasenotes/notes/prepare-0.45-50118e5e6d110302.yaml Outdated
Comment thread releasenotes/notes/prepare-0.45-50118e5e6d110302.yaml Outdated
:class:`.XGate` will be a reference to the first one. This results in a reduced memory and
construction overhead when using multiple gates of the same type in a circuit.
To realize this feature, new base classes have been
introduced: :class:`.SingletonInstruction` and :class:`.SingletonGate`. See feature notes for more details.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we use a ref for the feature notes here?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can save this for a post-release doc fix if we want. It's not critical.

Comment thread releasenotes/config.yaml
---
encoding: utf8
default_branch: main
collapse_pre_releases: true
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might need to change the pre_release_tag_re, the default looks like it should work: (?P<pre_release>\.v?\d+(?:[ab]|rc)+\d*)$ but I've had issues with it not collapsing pre-releases in the past. But we can fix this post release, because I'm not sure there is a way to check this until we have the tag.

Comment thread releasenotes/notes/fix-plot-state-city-viz-2963c83bcf3d3347.yaml Outdated
Comment thread releasenotes/notes/0.45/remove-deprecated-code-in-0.22.0-139fa09ee0cc6df9.yaml Outdated
Comment thread releasenotes/notes/0.45/removed_deprecated_0.21-6c93f7bbc50ae40e.yaml Outdated
Comment thread releasenotes/notes/0.45/remove-deprecated-code-in-0.19-a97ccfec62405b9a.yaml Outdated
Comment thread releasenotes/notes/0.45/removed_deprecated_0.21-6c93f7bbc50ae40e.yaml Outdated
Comment thread qiskit/circuit/__init__.py Outdated
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
mtreinish previously approved these changes Nov 2, 2023
Copy link
Copy Markdown
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, pending a rebase on the last few bugfix PRs. There a few small things that we can fix post-release if they're needed. I assume we'll have some post release reno things to adjust as this is our first release using the reno directive in sphinx (instead of a manual copy and paste of the generated rst) so we can take care of all of this at once.

Thanks for all the hard work wrangling this release!

@ElePT ElePT removed the on hold Can not fix yet label Nov 3, 2023
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
@jakelishman jakelishman enabled auto-merge November 3, 2023 11:04
@mtreinish mtreinish disabled auto-merge November 3, 2023 11:22
@mtreinish
Copy link
Copy Markdown
Member

I've turned the targeting computer off and I'm just going to admin merge this after CI passes so we avoid a second round of CI from the merge queue. This way we don't have to wait another hour to tag the release

@jakelishman
Copy link
Copy Markdown
Member

hDMkgI.mp4

@mtreinish mtreinish merged commit 33ed163 into Qiskit:stable/0.45 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants