Prepare 0.45.0 release#11169
Conversation
mtreinish
left a comment
There was a problem hiding this comment.
A couple quick notes, I haven't finished my detailed review yet. But figured in the interest of time I'd push what I had so far before stepping away for a little bit.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
|
One or more of the the following people are requested to review this:
|
| - [features_algorithms, Algorithms Features] | ||
| - [features_circuits, Circuits Features] | ||
| - [features_primitives, Primitives Features] | ||
| - [features_providers, Providers Features] | ||
| - [features_pulse, Pulse Features] |
There was a problem hiding this comment.
These should all be marked as subsections. From https://docs.openstack.org/reno/latest/user/usage.html
You can optionally include a number from 1 to 3 at the end of the list to mark the entry as a subsection. By default, each section has the number 1, which represents a top-level section. Use 2 and 3 for subsections and subsubsections. For example, ['features', 'New Features', 1], ['features_command_line', 'Command Line', 2], and ['features_command_line_ios', 'iOS', 3]. The order of this option matters; define subsections right after their ancestor sections.
There was a problem hiding this comment.
This is how I originally tried to implement the subsections, but I kept getting docs build failures like this one saying CRITICAL: Title level inconsistent:, and this is the only fix I could find that worked. If you have any suggestions on how I could address those without removing the "2", please let me know.
| :class:`.XGate` will be a reference to the first one. This results in a reduced memory and | ||
| construction overhead when using multiple gates of the same type in a circuit. | ||
| To realize this feature, new base classes have been | ||
| introduced: :class:`.SingletonInstruction` and :class:`.SingletonGate`. See feature notes for more details. |
There was a problem hiding this comment.
Could we use a ref for the feature notes here?
There was a problem hiding this comment.
We can save this for a post-release doc fix if we want. It's not critical.
| --- | ||
| encoding: utf8 | ||
| default_branch: main | ||
| collapse_pre_releases: true |
There was a problem hiding this comment.
We might need to change the pre_release_tag_re, the default looks like it should work: (?P<pre_release>\.v?\d+(?:[ab]|rc)+\d*)$ but I've had issues with it not collapsing pre-releases in the past. But we can fix this post release, because I'm not sure there is a way to check this until we have the tag.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
left a comment
There was a problem hiding this comment.
This LGTM, pending a rebase on the last few bugfix PRs. There a few small things that we can fix post-release if they're needed. I assume we'll have some post release reno things to adjust as this is our first release using the reno directive in sphinx (instead of a manual copy and paste of the generated rst) so we can take care of all of this at once.
Thanks for all the hard work wrangling this release!
This reverts commit 1b8a610.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
|
I've turned the targeting computer off and I'm just going to admin merge this after CI passes so we avoid a second round of CI from the merge queue. This way we don't have to wait another hour to tag the release |
hDMkgI.mp4 |
Summary
This commit prepares the 0.45.0 release, this involves 3 steps:
As we did in 0.25, we're using a pre-release feature in reno to add subsections to the release notes. Subsections are added to the features, deprecations, and upgrade sections for:
I have also added the following sections:
Details and comments
TODO:
Missing PRs tagged for 0.45:
Formatting and typo issues in qiskit.transpiler.Target #11164 -> docs-> pushed to 0.45.1small typos and spelling issues in passes docs #11163 -> docs-> pushed to 0.45.1Fix circuit drawer returning qubit[register] names for input #11096 -> visualization bugfix-> pushed to 0.45.1