Formatting and typo issues in qiskit.transpiler.Target#11164
Merged
Conversation
1ucian0
added
documentation
Collaborator
|
One or more of the the following people are requested to review this:
|
jakelishman
reviewed
Nov 1, 2023
| if None not in self.qargs and any(len(x) > 2 for x in self.qargs): | ||
| logger.warning( | ||
| "This Target object contains multiqubit gates that " | ||
| "This Target object contains multi-qubit gates that " |
Member
There was a problem hiding this comment.
"multiqubit" is fine (especially in US English), it's just a constructed word.
Contributor
There was a problem hiding this comment.
Also a small note here, should this change stay, the log assert in the target unit test would have to be modified to add the hyphen (this is why CI currently fails): https://github.com/Qiskit/qiskit/blob/main/test/python/transpiler/test_target.py#L558
Pull Request Test Coverage Report for Build 6749880230
💛 - Coveralls |
jakelishman
approved these changes
Nov 4, 2023
mergify Bot
pushed a commit
that referenced
this pull request
Nov 4, 2023
* formatting and typo issues in qiskit.transpiler.Target * #11164 (comment) * #11164 (comment) (cherry picked from commit 2818cf0)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Nov 4, 2023
* formatting and typo issues in qiskit.transpiler.Target * #11164 (comment) * #11164 (comment) (cherry picked from commit 2818cf0) Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Some small typo issues in
qiskit.transpiler.Target