small typos and spelling issues in passes docs by 1ucian0 · Pull Request #11163 · Qiskit/qiskit

1ucian0 · 2023-11-01T10:04:41Z

Summary

While reading pass docs, some typos and formatting issues

qiskit-bot · 2023-11-01T10:04:48Z

One or more of the the following people are requested to review this:

@Qiskit/terra-core
@nkanazawa1989

jakelishman · 2023-11-01T10:22:01Z

 # that they have been altered from the originals.

-"""Reduce 1Q gate complexity by commuting through 2Q gates and resynthesizing."""
+"""Reduce 1Q gate complexity by commuting through 2Q gates and re-synthesizing."""


Using the hyphen in constructed words like this (and multiqubit, etc) is I think falling out of fashion a bit, especially in US English. It's a bit more common to put one in still in British English, I think, but generally it's fine without it.

Thanks, addressing it in 4f77873

…ge_docs/7

Co-authored-by: Jake Lishman <jake@binhbar.com>

coveralls · 2023-11-11T17:54:07Z

Pull Request Test Coverage Report for Build 6841938652

Warning: This coverage report may be inaccurate.

We've detected an issue with your CI configuration that might affect the accuracy of this pull request's coverage report.
To ensure accuracy in future PRs, please see these guidelines.
A quick fix for this PR: rebase it; your next report should be accurate.

13 of 13 (100.0%) changed or added relevant lines in 9 files are covered.
374 unchanged lines in 36 files lost coverage.
Overall coverage decreased (-1.0%) to 85.909%

Files with Coverage Reduction	New Missed Lines	%
qiskit/circuit/library/blueprintcircuit.py	1	92.24%
qiskit/circuit/library/evolved_operator_ansatz.py	1	85.12%
qiskit/opflow/state_fns/operator_state_fn.py	1	80.22%
qiskit/opflow/state_fns/state_fn.py	1	81.88%
qiskit/primitives/backend_sampler.py	1	98.84%
qiskit/primitives/utils.py	1	87.8%
qiskit/providers/backend.py	1	81.76%
qiskit/providers/basicaer/basicaerprovider.py	1	94.34%
qiskit/quantum_info/operators/symplectic/pauli_list.py	1	83.16%
qiskit/quantum_info/operators/symplectic/pauli.py	1	83.47%

Totals
Change from base Build 6833483304:	-1.0%
Covered Lines:	65907
Relevant Lines:	76717

💛 - Coveralls

…a1b5571de4b9c1b58f43b4fa4c31#r1378615081

…de4b9c1b58f43b4fa4c31#r1378616728

…de4b9c1b58f43b4fa4c31#r1378617566

…ion.py Co-authored-by: Jake Lishman <jake@binhbar.com>

… into small_change_docs/7

…de4b9c1b58f43b4fa4c31#r1378621645

…de4b9c1b58f43b4fa4c31#r1378621956

…de4b9c1b58f43b4fa4c31#r1378625161

Co-authored-by: Jake Lishman <jake@binhbar.com>

… into small_change_docs/7

* small typos and spelling issues in passes docs * revert #11163 (comment) * Update qiskit/transpiler/passes/analysis/dag_longest_path.py Co-authored-by: Jake Lishman <jake@binhbar.com> * revert https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378615081 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378616728 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378617566 * Update qiskit/transpiler/passes/optimization/echo_rzx_weyl_decomposition.py Co-authored-by: Jake Lishman <jake@binhbar.com> * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378621645 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378621956 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378625161 * Update qiskit/transpiler/passes/optimization/template_optimization.py Co-authored-by: Jake Lishman <jake@binhbar.com> --------- Co-authored-by: Jake Lishman <jake@binhbar.com> (cherry picked from commit 87fcd71)

* small typos and spelling issues in passes docs * revert #11163 (comment) * Update qiskit/transpiler/passes/analysis/dag_longest_path.py Co-authored-by: Jake Lishman <jake@binhbar.com> * revert https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378615081 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378616728 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378617566 * Update qiskit/transpiler/passes/optimization/echo_rzx_weyl_decomposition.py Co-authored-by: Jake Lishman <jake@binhbar.com> * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378621645 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378621956 * https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571de4b9c1b58f43b4fa4c31#r1378625161 * Update qiskit/transpiler/passes/optimization/template_optimization.py Co-authored-by: Jake Lishman <jake@binhbar.com> --------- Co-authored-by: Jake Lishman <jake@binhbar.com> (cherry picked from commit 87fcd71) Co-authored-by: Luciano Bello <bel@zurich.ibm.com>

small typos and spelling issues in passes docs

c87ce14

1ucian0 added documentation Something is not clear or an error documentation stable backport potential Make Mergify open a backport PR to the most recent stable branch on merge. labels Nov 1, 2023

1ucian0 added this to the 0.45.0 milestone Nov 1, 2023

1ucian0 requested a review from a team as a code owner November 1, 2023 10:04

jakelishman reviewed Nov 1, 2023

View reviewed changes

1ucian0 added the Changelog: None Do not include in the GitHub Release changelog. label Nov 1, 2023

ElePT mentioned this pull request Nov 2, 2023

Prepare 0.45.0 release #11169

Merged

13 tasks

ElePT modified the milestones: 0.45.0, 0.45.1 Nov 2, 2023

1ucian0 and others added 3 commits November 11, 2023 18:20

Merge branch 'main' of github.com:Qiskit/qiskit-terra into small_chan…

73f7153

…ge_docs/7

revert Qiskit#11163 (comment)

62f391e

Update qiskit/transpiler/passes/analysis/dag_longest_path.py

42fd212

Co-authored-by: Jake Lishman <jake@binhbar.com>

1ucian0 and others added 10 commits November 12, 2023 17:29

revert https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714…

2d6826e

…a1b5571de4b9c1b58f43b4fa4c31#r1378615081

https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571…

f654a78

…de4b9c1b58f43b4fa4c31#r1378616728

https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571…

e280530

…de4b9c1b58f43b4fa4c31#r1378617566

Update qiskit/transpiler/passes/optimization/echo_rzx_weyl_decomposit…

1ef1794

…ion.py Co-authored-by: Jake Lishman <jake@binhbar.com>

Merge branch 'small_change_docs/7' of github.com:1ucian0/qiskit-terra…

a326236

… into small_change_docs/7

https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571…

4f77873

…de4b9c1b58f43b4fa4c31#r1378621645

https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571…

8b72078

…de4b9c1b58f43b4fa4c31#r1378621956

https://github.com/Qiskit/qiskit/pull/11163/files/c87ce1431714a1b5571…

0daa269

…de4b9c1b58f43b4fa4c31#r1378625161

Update qiskit/transpiler/passes/optimization/template_optimization.py

bb50f91

Co-authored-by: Jake Lishman <jake@binhbar.com>

Merge branch 'small_change_docs/7' of github.com:1ucian0/qiskit-terra…

d6a5802

… into small_change_docs/7

jakelishman approved these changes Nov 14, 2023

View reviewed changes

jakelishman added this pull request to the merge queue Nov 14, 2023

Merged via the queue into Qiskit:main with commit 87fcd71 Nov 14, 2023

mergify Bot mentioned this pull request Nov 14, 2023

small typos and spelling issues in passes docs (backport #11163) #11237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

small typos and spelling issues in passes docs#11163

small typos and spelling issues in passes docs#11163
jakelishman merged 14 commits into
Qiskit:mainfrom
1ucian0:small_change_docs/7

1ucian0 commented Nov 1, 2023

Uh oh!

qiskit-bot commented Nov 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakelishman Nov 1, 2023

Uh oh!

1ucian0 Nov 12, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Nov 11, 2023 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

1ucian0 commented Nov 1, 2023

Summary

Uh oh!

qiskit-bot commented Nov 1, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jakelishman Nov 1, 2023

Choose a reason for hiding this comment

Uh oh!

1ucian0 Nov 12, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coveralls commented Nov 11, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 6841938652

Warning: This coverage report may be inaccurate.

💛 - Coveralls

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

coveralls commented Nov 11, 2023 •

edited

Loading