-
Notifications
You must be signed in to change notification settings - Fork 3k
only publish images if image tests run #11123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 7 commits
a6957ae
3c08096
6a91420
df713f0
9cdae9f
6dc542a
6bbe5e6
36112b4
e17045c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -29,6 +29,7 @@ jobs: | |||||
| QISKIT_SUPPRESS_PACKAGING_WARNINGS: Y | ||||||
| PIP_CACHE_DIR: $(Pipeline.Workspace)/.pip | ||||||
| QISKIT_TEST_CAPTURE_STREAMS: 1 | ||||||
| HAVE_VISUAL_TESTS_RUN: false | ||||||
|
|
||||||
| steps: | ||||||
| - task: UsePythonVersion@0 | ||||||
|
|
@@ -197,14 +198,16 @@ jobs: | |||||
| env: | ||||||
| SETUPTOOLS_ENABLE_FEATURES: "legacy-editable" | ||||||
|
|
||||||
| - bash: image_tests/bin/python -m unittest discover -v test/visual | ||||||
| - bash: | | ||||||
| echo "##vso[task.setvariable variable=HAVE_VISUAL_TESTS_RUN;]true" | ||||||
| image_tests/bin/python -m unittest discover -v test/visual | ||||||
| displayName: 'Run image test' | ||||||
| env: | ||||||
| # Needed to suppress a warning in jupyter-core 5.x by eagerly migrating to | ||||||
| # a new internal interface that will be the default in jupyter-core 6.x. | ||||||
| # This variable should become redundant on release of jupyter-core 6. | ||||||
| JUPYTER_PLATFORM_DIRS: 1 | ||||||
|
|
||||||
| - task: ArchiveFiles@2 | ||||||
| displayName: Archive visual test failure diffs | ||||||
| inputs: | ||||||
|
|
@@ -213,7 +216,7 @@ jobs: | |||||
| archiveType: tar | ||||||
| archiveFile: '$(Build.ArtifactStagingDirectory)/visual_test_failures.tar.gz' | ||||||
| verbose: true | ||||||
| condition: failed() | ||||||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| - task: ArchiveFiles@2 | ||||||
| displayName: Archive circuit results | ||||||
|
|
@@ -222,7 +225,7 @@ jobs: | |||||
| archiveType: tar | ||||||
| archiveFile: '$(Build.ArtifactStagingDirectory)/circuit_results.tar.gz' | ||||||
| verbose: true | ||||||
| condition: failed() | ||||||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| - task: ArchiveFiles@2 | ||||||
| displayName: Archive graph results | ||||||
|
|
@@ -231,7 +234,7 @@ jobs: | |||||
| archiveType: tar | ||||||
| archiveFile: '$(Build.ArtifactStagingDirectory)/graph_results.tar.gz' | ||||||
| verbose: true | ||||||
| condition: failed() | ||||||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
|
|
||||||
| - task: PublishBuildArtifacts@1 | ||||||
| displayName: 'Publish image test failure diffs' | ||||||
|
|
@@ -240,4 +243,4 @@ jobs: | |||||
| artifactName: 'image_test_failure_img_diffs' | ||||||
| Parallel: true | ||||||
| ParallelCount: 8 | ||||||
| condition: failed() | ||||||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | ||||||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.