only publish images if image tests run#11123
Merged
Merged
Conversation
Collaborator
|
One or more of the the following people are requested to review this:
|
Contributor
Author
|
Will re convert after CI has verified correctly I've removed temporary test changes. |
Collaborator
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6663551130
💛 - Coveralls |
1ucian0
added
type: qa
jakelishman
reviewed
Oct 27, 2023
Member
jakelishman
left a comment
jakelishman
left a comment
There was a problem hiding this comment.
Thanks for this - this looks like the kind of solution I was envisaging!
Minor: please could we tidy up the trailing whitespace?
| # This variable should become redundant on release of jupyter-core 6. | ||
| JUPYTER_PLATFORM_DIRS: 1 | ||
|
|
||
| archiveFile: '$(Build.ArtifactStagingDirectory)/visual_test_failures.tar.gz' | ||
| verbose: true | ||
| condition: failed() | ||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
Member
There was a problem hiding this comment.
Suggested change
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | |
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
| archiveFile: '$(Build.ArtifactStagingDirectory)/circuit_results.tar.gz' | ||
| verbose: true | ||
| condition: failed() | ||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
Member
There was a problem hiding this comment.
Suggested change
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | |
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
| archiveFile: '$(Build.ArtifactStagingDirectory)/graph_results.tar.gz' | ||
| verbose: true | ||
| condition: failed() | ||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
Member
There was a problem hiding this comment.
Suggested change
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | |
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
| Parallel: true | ||
| ParallelCount: 8 | ||
| condition: failed() | ||
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
Member
There was a problem hiding this comment.
Suggested change
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) | |
| condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true')) |
jakelishman
added
the
stable backport potential
mergify Bot
pushed a commit
that referenced
this pull request
Oct 27, 2023
* only publish images if image tests run * fix indent in bash command * fix condition syntax * set value in the image test * test runner stopping correctly on fail * revert purposeful failure * tidy up trailing whitespace (cherry picked from commit 905cfde)
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Oct 28, 2023
* only publish images if image tests run * fix indent in bash command * fix condition syntax * set value in the image test * test runner stopping correctly on fail * revert purposeful failure * tidy up trailing whitespace (cherry picked from commit 905cfde) Co-authored-by: Angelo Danducci <angelo.danducci.ii@ibm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #10968
Details and comments
Need to open PR to verify CI tests work correctly, fixes the flake of too early a failure causing image publishing to fail