Skip to content

only publish images if image tests run #11123

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakelishman merged 9 commits into from
Oct 27, 2023
Merged

only publish images if image tests run #11123

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a6957ae
only publish images if image tests run
AngeloDanducci Oct 26, 2023
3c08096
fix indent in bash command
AngeloDanducci Oct 26, 2023
6a91420
fix condition syntax
AngeloDanducci Oct 26, 2023
df713f0
set value in the image test
AngeloDanducci Oct 26, 2023
9cdae9f
test runner stopping correctly on fail
AngeloDanducci Oct 27, 2023
6dc542a
revert purposeful failure
AngeloDanducci Oct 27, 2023
6bbe5e6
Merge branch 'main' into ad-10968
AngeloDanducci Oct 27, 2023
36112b4
tidy up trailing whitespace
AngeloDanducci Oct 27, 2023
e17045c
Merge branch 'ad-10968' of https://github.com/AngeloDanducci/qiskit i…
AngeloDanducci Oct 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions .azure/test-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
QISKIT_SUPPRESS_PACKAGING_WARNINGS: Y
PIP_CACHE_DIR: $(Pipeline.Workspace)/.pip
QISKIT_TEST_CAPTURE_STREAMS: 1
HAVE_VISUAL_TESTS_RUN: false

steps:
- task: UsePythonVersion@0
Expand Down Expand Up @@ -197,7 +198,9 @@ jobs:
env:
SETUPTOOLS_ENABLE_FEATURES: "legacy-editable"

- bash: image_tests/bin/python -m unittest discover -v test/visual
- bash: |
echo "##vso[task.setvariable variable=HAVE_VISUAL_TESTS_RUN;]true"
image_tests/bin/python -m unittest discover -v test/visual
displayName: 'Run image test'
env:
# Needed to suppress a warning in jupyter-core 5.x by eagerly migrating to
Expand All @@ -213,7 +216,7 @@ jobs:
archiveType: tar
archiveFile: '$(Build.ArtifactStagingDirectory)/visual_test_failures.tar.gz'
verbose: true
condition: failed()
condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))

- task: ArchiveFiles@2
displayName: Archive circuit results
Expand All @@ -222,7 +225,7 @@ jobs:
archiveType: tar
archiveFile: '$(Build.ArtifactStagingDirectory)/circuit_results.tar.gz'
verbose: true
condition: failed()
condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))

- task: ArchiveFiles@2
displayName: Archive graph results
Expand All @@ -231,7 +234,7 @@ jobs:
archiveType: tar
archiveFile: '$(Build.ArtifactStagingDirectory)/graph_results.tar.gz'
verbose: true
condition: failed()
condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))

- task: PublishBuildArtifacts@1
displayName: 'Publish image test failure diffs'
Expand All @@ -240,4 +243,4 @@ jobs:
artifactName: 'image_test_failure_img_diffs'
Parallel: true
ParallelCount: 8
condition: failed()
condition: and(failed(), eq(variables.HAVE_VISUAL_TESTS_RUN, 'true'))