Enable disabled pylint rules pt. 2#137
Merged
Merged
Conversation
daka1510
reviewed
Feb 4, 2022
Comment on lines
+71
to
+78
| consider-using-f-string, # unnecessary | ||
| consider-using-with, # TODO: investigate / re-enable | ||
| docstring-first-line-empty, # TODO: investigate / re-enable | ||
| docstring-first-line-empty, # unnecessary | ||
| duplicate-code, # too verbose | ||
| fixme, # avoid that to do annotations show up as warnings | ||
| invalid-name, # TODO: investigate / re-enable | ||
| missing-param-doc, # TODO: investigate / re-enable (issues with kwargs docs) | ||
| missing-param-doc, # unnecessary | ||
| no-else-return, # relax "elif" after a clause with a return | ||
| no-member, # TODO: investigate / re-enable | ||
| no-member, # unecessary |
Contributor
There was a problem hiding this comment.
It may help future contributors (or ourselves) to include a short explanation why you suggest that these rules are unnecessary.
daka1510
approved these changes
Feb 7, 2022
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
* Fix QAOA and VQE after Terra 0.20 release * is_built in HWQAOA * ensure is_built is correctly set Co-authored-by: Julien Gacon <gaconju@gmail.com>
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
blakejohnson
pushed a commit
to blakejohnson/qiskit-ibm-runtime
that referenced
this pull request
May 26, 2023
…" (Qiskit#138)" This reverts commit 2638e72.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I'm indifferent about most of the remaining rules, but this PR takes care of :
invalid-name,super-with-arguments, andbad-mcs-classmethod-argumentHighlighted the remaining rules in a comment here
Details and comments
Fixes part of #42