Skip to content

Enabled disabled pylint rules pt.3#140

Merged
daka1510 merged 6 commits into
Qiskit:mainfrom
kt474:pylint-rules-part-3
Feb 8, 2022
Merged

Enabled disabled pylint rules pt.3#140
daka1510 merged 6 commits into
Qiskit:mainfrom
kt474:pylint-rules-part-3

Conversation

@kt474
Copy link
Copy Markdown
Contributor

@kt474 kt474 commented Feb 4, 2022

Summary

Indifferent about the remaining rules, this PR takes care of:
unspecified-encoding
consider-using-with: should probably stay disabled - there are cases where using with is not necessarily beneficial
raise-missing-from: not every exception needs from, and adding from None seems too verbose

Details and comments

Fixes part of #42

@kt474 kt474 marked this pull request as ready for review February 7, 2022 00:51
@daka1510
Copy link
Copy Markdown
Contributor

daka1510 commented Feb 7, 2022

@kt474 can you resolve the conflicts (that came in via the integration of #137)?

@daka1510 daka1510 merged commit 9f1df00 into Qiskit:main Feb 8, 2022
@kt474 kt474 deleted the pylint-rules-part-3 branch March 15, 2023 17:44
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
…37-fix-vqe-qaoa-terra20

[Don't merge] Redeploy VQE and QAOA fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants