Skip to content

Fix staging integration tests against legacy environment#138

Merged
rathishcholarajan merged 2 commits into
Qiskit:mainfrom
daka1510:fix-staging-integration-tests
Feb 3, 2022
Merged

Fix staging integration tests against legacy environment#138
rathishcholarajan merged 2 commits into
Qiskit:mainfrom
daka1510:fix-staging-integration-tests

Conversation

@daka1510
Copy link
Copy Markdown
Contributor

@daka1510 daka1510 commented Feb 3, 2022

Summary

Change makes sure to run pulse tests only against pulse backends. Needed for staging where simulators pretend to be real backends but don't have pulse defaults.

Details and comments

Fixes broken integration tests against legacy-staging

FAIL: test_device_properties_and_defaults (test.test_basic_server_paths.TestBasicServerPaths) (hgp='***')
Test device properties and defaults.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/qiskit-ibm-runtime/qiskit-ibm-runtime/test/test_basic_server_paths.py", line 55, in test_device_properties_and_defaults
    self.assertIsNotNone(pulse_backends[0].defaults())
AssertionError: unexpectedly None

Verified locally

image

Copy link
Copy Markdown
Member

@rathishcholarajan rathishcholarajan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rathishcholarajan rathishcholarajan merged commit 00963e7 into Qiskit:main Feb 3, 2022
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
blakejohnson pushed a commit to blakejohnson/qiskit-ibm-runtime that referenced this pull request May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants