Further fixes to make the code usuable in librustzcash#185
Closed
vivek-arte wants to merge 2 commits intozsa1from
Closed
Further fixes to make the code usuable in librustzcash#185vivek-arte wants to merge 2 commits intozsa1from
librustzcash#185vivek-arte wants to merge 2 commits intozsa1from
Conversation
…usable in librustzcash
PR Summary
|
… the error handling in orchard
| signature: IssueAuthSig::decode(data).unwrap(), | ||
| } | ||
| /// Constructs a `Signed` from an `IssueAuthSig`. | ||
| pub fn from_sig(signature: IssueAuthSig<ZSASchnorr>) -> Self { |
Collaborator
There was a problem hiding this comment.
I prefer to call this function new rather than from_sig.
I prefer if it is the first function in the impl Signed block.
Collaborator
|
Implemented in #181 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some visibility changes to methods needed for the corresponding encoding change in librustzcash