Supporting the change in encoding of ik and issueAuthSig#136
Supporting the change in encoding of ik and issueAuthSig#136vivek-arte wants to merge 4 commits intozsa1from
ik and issueAuthSig#136Conversation
PR Summary
|
a657424 to
4b16d80
Compare
|
|
||
| let isk = IssuanceAuthorizingKey::from_bytes([1; 32]).unwrap(); | ||
| let ik = IssuanceValidatingKey::from(&isk); | ||
| let isk = IssueAuthKey::from_bytes(&[1u8; 32]).unwrap(); |
There was a problem hiding this comment.
I prefer to specify that it is a ZSASchnorr validating key to avoid any ambiguity.
| let isk = IssueAuthKey::from_bytes(&[1u8; 32]).unwrap(); | |
| let isk = IssueAuthKey::<ZSASchnorr>::from_bytes(&[1u8; 32]).unwrap(); |
| ) | ||
| })?; | ||
| Ok(Signed::from_data(bytes)) | ||
| Ok(Signed::from_sig(sig)) |
There was a problem hiding this comment.
I prefer to call this function new rather than from_sig.
|
Included into #129 |
This makes the changes needed to support the change in the encoding of
ikandissueAuthSig, as performed in QED-it/orchard#185, QED-it/orchard#182 and QED-it/orchard#184, and in QED-it/zcash-test-vectors#31.