Skip to content

Further fixes to make the code usuable in librustzcash #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vivek-arte wants to merge 2 commits into from
Closed

Further fixes to make the code usuable in librustzcash #185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b1d53c5
expanding visibility of encode and decode of IssueAuthSig to make it …
vivek-arte Sep 5, 2025
33ab400
changing from_data function to from_sig function to take advantage of…
vivek-arte Sep 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions src/issuance.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,11 +250,9 @@ impl Signed {
&self.signature
}

/// Constructs a `Signed` from a byte array containing an `IssueAuthSig` in raw bytes.
pub fn from_data(data: &[u8]) -> Self {
Signed {
signature: IssueAuthSig::decode(data).unwrap(),
}
/// Constructs a `Signed` from an `IssueAuthSig`.
pub fn from_sig(signature: IssueAuthSig<ZSASchnorr>) -> Self {
Copy link
Collaborator

@ConstanceBeguier ConstanceBeguier Sep 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to call this function new rather than from_sig.
I prefer if it is the first function in the impl Signed block.

Signed { signature }
}
}

Expand Down
4 changes: 2 additions & 2 deletions src/issuance_auth.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ impl IssueAuthSig<ZSASchnorr> {
/// defined in [ZIP 227][issueauthsig].
///
/// [issueauthsig]: https://zips.z.cash/zip-0227#issuance-authorization-signing-and-validation
pub(crate) fn encode(&self) -> Vec<u8> {
pub fn encode(&self) -> Vec<u8> {
let sig_bytes = self.0.to_bytes().to_vec();
let mut encoded =
Vec::with_capacity(size_of_val(&ZSASchnorr::ALGORITHM_BYTE) + sig_bytes.len());
Expand All @@ -228,7 +228,7 @@ impl IssueAuthSig<ZSASchnorr> {
/// in [ZIP 227][issueauthsig].
///
/// [issueauthsig]: https://zips.z.cash/zip-0227#issuance-authorization-signing-and-validation
pub(crate) fn decode(bytes: &[u8]) -> Result<Self, Error> {
pub fn decode(bytes: &[u8]) -> Result<Self, Error> {
if let Some((&algorithm_byte, key_bytes)) = bytes.split_first() {
if algorithm_byte == ZSASchnorr::ALGORITHM_BYTE {
return schnorr::Signature::try_from(key_bytes)
Expand Down
Loading