Skip to content

Exclude non-native assets from value_balance #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexeykoren merged 2 commits into from
Nov 13, 2024
Merged

Exclude non-native assets from value_balance #120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5428639
Exclude non-native assets from value_balance
alexeykoren Nov 12, 2024
6999dad
Cleanup
alexeykoren Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/builder.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,7 +619,7 @@ impl Builder {
&self.outputs
}

/// The net value of the bundle to be built. The value of all spends,
/// The net native (ZEC) value of the bundle to be built. The value of all spends,
/// minus the value of all outputs.
///
/// Useful for balancing a transaction, as the value balance of an individual bundle
Expand All @@ -633,10 +633,12 @@ impl Builder {
let value_balance = self
.spends
.iter()
.filter(|spend| spend.note.asset().is_native().into())
.map(|spend| spend.note.value() - NoteValue::zero())
.chain(
self.outputs
.iter()
.filter(|output| output.asset.is_native().into())
.map(|output| NoteValue::zero() - output.value),
)
.try_fold(ValueSum::zero(), |acc, note_value| acc + note_value)
Expand Down