Skip to content

Updating test vectors for the change in transaction format structure#94

Merged
PaulLaux merged 1 commit into
update_orchard_crate_20250115from
update_test_vectors_for_action_groups
Jan 20, 2025
Merged

Updating test vectors for the change in transaction format structure#94
PaulLaux merged 1 commit into
update_orchard_crate_20250115from
update_test_vectors_for_action_groups

Conversation

@vivek-arte
Copy link
Copy Markdown

This PR makes the changes to the test vectors that have been made in QED-it/zcash-test-vectors#24, to reflect the updated transaction format that uses Action Groups, and the updated computations for the SIGHASH and the Authorizing Data Commitment.

@vivek-arte vivek-arte force-pushed the update_test_vectors_for_action_groups branch from 9997574 to 65ffb8a Compare January 18, 2025 14:06
Copy link
Copy Markdown
Collaborator

@alexeykoren alexeykoren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green == good

Copy link
Copy Markdown
Collaborator

@PaulLaux PaulLaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved, since the test vectors are not expected to change.

@PaulLaux PaulLaux merged commit 00b0b2b into update_orchard_crate_20250115 Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants