Updating test vectors for Action Groups#24
Merged
Conversation
vivek-arte
force-pushed
the
action_group_update
branch
from
5178665 to
d4d99b1
Compare
vivek-arte
force-pushed
the
action_group_update
branch
from
d4d99b1 to
ae2d95e
Compare
PaulLaux
reviewed
Jan 19, 2025
PaulLaux
left a comment
PaulLaux
left a comment
There was a problem hiding this comment.
Good overall. Added some comments, mostly cosmetics for this PR and the zip.
PaulLaux
pushed a commit
to QED-it/librustzcash
that referenced
this pull request
Jan 20, 2025
…94) This PR makes the changes to the test vectors that have been made in QED-it/zcash-test-vectors#24, to reflect the updated transaction format that uses Action Groups, and the updated computations for the SIGHASH and the Authorizing Data Commitment.
PaulLaux
previously approved these changes
Jan 28, 2025
PaulLaux
previously approved these changes
Feb 6, 2025
vivek-arte
added a commit
to QED-it/zips
that referenced
this pull request
Feb 18, 2025
This performs various improvements to the naming of the branches of the TxID and Signature Digests, and the Authorizing Data Commitment, as initially suggested in the review of QED-it/zcash-test-vectors#24.
str4d
pushed a commit
to zcash/zips
that referenced
this pull request
Feb 26, 2025
This performs various improvements to the naming of the branches of the TxID and Signature Digests, and the Authorizing Data Commitment, as initially suggested in the review of QED-it/zcash-test-vectors#24. (adapted from commit QED-it/zips@8662fd6)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the changes corresponding to the updates in the V6 transaction format and digest computation, especially for the update to include Action Groups.