Update orchard crate dependency#93
Merged
alexeykoren merged 9 commits intoJan 21, 2025
Merged
Conversation
… than zcash_primitives so that tests pass
alexeykoren
requested changes
Jan 18, 2025
Collaborator
alexeykoren
left a comment
alexeykoren
left a comment
There was a problem hiding this comment.
Looking good! Waiting for test vectors
…94) This PR makes the changes to the test vectors that have been made in QED-it/zcash-test-vectors#24, to reflect the updated transaction format that uses Action Groups, and the updated computations for the SIGHASH and the Authorizing Data Commitment.
alexeykoren
approved these changes
Jan 20, 2025
PaulLaux
reviewed
Jan 21, 2025
| const V6_TX_VERSION: u32 = 6; | ||
| #[cfg(zcash_unstable = "nu6" /* TODO nu7 */ )] | ||
| const V6_VERSION_GROUP_ID: u32 = 0x124A69F8; // TODO ??? | ||
| const V6_VERSION_GROUP_ID: u32 = 0x77777777; // TODO ??? |
Collaborator
There was a problem hiding this comment.
Do we have values for V6 anywhere? Anyway this one is consistent with python so I suggest to merge as is and probably create new PR with final values when we have them
Closed
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the orchard dependency used in librustzcash to a later version of our orchard repository fork (specifically, commit
3dbdbc52c6e2ffeca015ae6eb80ad7f1c870384d: QED-it/orchard@3dbdbc5).The reference test vectors are not updated in this PR, and will be done in a subsequent PR (#94). This explains the 2 failing CI checks.