Skip to content

docs(gpu-sharing): fix hami-core install flags to match chart values - #1925

Merged
enoodle merged 1 commit into
kai-scheduler:mainfrom
mesutoezdil:fix/hami-docs-helm-flags
Jul 15, 2026
Merged

docs(gpu-sharing): fix hami-core install flags to match chart values#1925
enoodle merged 1 commit into
kai-scheduler:mainfrom
mesutoezdil:fix/hami-docs-helm-flags

Conversation

@mesutoezdil

@mesutoezdil mesutoezdil commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

the docs enable hami-core with --set scheduler.gpuSharing.enabled=true --set scheduler.gpuSharing.hamicoreEnabled=true, but those keys don't exist in the kai-scheduler chart (checked v0.16.0 through main), so helm silently ignores them and nothing gets enabled.

fix: use the real values --set global.gpuSharing=true --set binder.plugins.hamicore.enabled=true. verified with helm template.

fixes #1912

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: a7b82224-60b3-493e-baa5-f02d0a4c20a2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@mesutoezdil

mesutoezdil commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

cc @archlitchi @enoodle

scheduler.gpuSharing.enabled / scheduler.gpuSharing.hamicoreEnabled don't exist in the chart values.yaml (checked v0.16.0 through main); helm ignores unknown --set paths so nothing gets enabled. Use global.gpuSharing and binder.plugins.hamicore.enabled.

Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
@mesutoezdil
mesutoezdil force-pushed the fix/hami-docs-helm-flags branch from 1f497fb to baed4d4 Compare July 15, 2026 19:49
@enoodle
enoodle enabled auto-merge July 15, 2026 22:06
@enoodle
enoodle added this pull request to the merge queue Jul 15, 2026
Merged via the queue into kai-scheduler:main with commit f23d1e4 Jul 15, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot find parameter scheduler.gpuSharing.hamicoreEnabled in values.yaml file

2 participants