docs(gpu-sharing): fix hami-core install flags to match chart values - #1925
Merged
Merged
Conversation
Contributor
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mesutoezdil
force-pushed
the
fix/hami-docs-helm-flags
branch
from
July 15, 2026 19:32
ad6685a to
1f497fb
Compare
Contributor
Author
This was referenced Jul 15, 2026
scheduler.gpuSharing.enabled / scheduler.gpuSharing.hamicoreEnabled don't exist in the chart values.yaml (checked v0.16.0 through main); helm ignores unknown --set paths so nothing gets enabled. Use global.gpuSharing and binder.plugins.hamicore.enabled. Signed-off-by: mesutoezdil <mesudozdil@gmail.com>
mesutoezdil
force-pushed
the
fix/hami-docs-helm-flags
branch
from
July 15, 2026 19:49
1f497fb to
baed4d4
Compare
enoodle
approved these changes
Jul 15, 2026
enoodle
enabled auto-merge
July 15, 2026 22:06
Merged
via the queue into
kai-scheduler:main
with commit Jul 15, 2026
f23d1e4
13 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the docs enable hami-core with
--set scheduler.gpuSharing.enabled=true --set scheduler.gpuSharing.hamicoreEnabled=true, but those keys don't exist in the kai-scheduler chart (checked v0.16.0 through main), so helm silently ignores them and nothing gets enabled.fix: use the real values
--set global.gpuSharing=true --set binder.plugins.hamicore.enabled=true. verified withhelm template.fixes #1912