Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dom-bind doesn't init tap recognizer #4509

Closed
valdrinkoshi opened this issue Apr 6, 2017 · 1 comment
Closed

dom-bind doesn't init tap recognizer #4509

valdrinkoshi opened this issue Apr 6, 2017 · 1 comment
Assignees
@kevinpschaaf
Labels
1.x-2.x compatibility 2.x p1

Comments

@valdrinkoshi
Copy link
Member

In 1.x logEventType would be invoked twice, in 2.x only once.

  <dom-bind>
    <template is="dom-bind">
      <button on-tap="logEventType" on-click="logEventType">button</button>
    </template>
  </dom-bind>

http://jsbin.com/lixujah/1/edit?html,console,output

It seems that in 2.x tap recognizer is not initialized
@valdrinkoshi valdrinkoshi mentioned this issue Apr 6, 2017
Merged
@kevinpschaaf kevinpschaaf assigned kevinpschaaf and unassigned dfreedm Apr 10, 2017
@kevinpschaaf
Copy link
Member

kevinpschaaf commented Apr 10, 2017 •
edited
Loading

Ok, for BC/hybrid we'll add Polymer.GestureEventListeners to dom-bind.

@kevinpschaaf kevinpschaaf mentioned this issue Apr 13, 2017
Merged
kevinpschaaf added a commit that referenced this issue Apr 13, 2017
@kevinpschaaf
Merge pull request #4530 from Polymer/4509-kschaaf-dom-bind-gestures
7da6ff4 
Add GestureEventListeners to dom-bind. Fixes #4509
valdrinkoshi added a commit to PolymerElements/iron-fit-behavior that referenced this issue Apr 14, 2017
@valdrinkoshi
remove workaround for Polymer/polymer#4509. Clearer comment of why flush
d968e50
valdrinkoshi added a commit to PolymerElements/iron-fit-behavior that referenced this issue May 12, 2017
@valdrinkoshi
remove workaround for Polymer/polymer#4509. Clearer comment of why flush
f01313a
valdrinkoshi added a commit to PolymerElements/iron-fit-behavior that referenced this issue May 12, 2017
@valdrinkoshi
2.0 preview (#64)
06f7844 
* port to 2.0

* use demo-pages-shared-styles (reverted)

* custom-elements-v1

* use new custom-style syntax

* use dom-bind and dom-repeat

* update deps

* resolve webcomponents v1, remove <content>

* variants

* script inside dom-module, remove <content>

* use wc-ce flag instead of wc-register

* update deps and resolutions

* Depend on test-fixture v2

* auto-generated: update repo for v2

* remove duplicate scripts

* fix safari9 tests

* update deps

* Point to Polymer 2.0 RC 1

* address feedback

* remove test-fixture dependency

* Fix demo for tap not being fired. Defer refit.

* revert comment indentation

* Update travis config

* flush and explain why

* remove workaround for Polymer/polymer#4509. Clearer comment of why flush

* [skip ci] update README

* Update travis config

* fix rebase errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinpschaaf kevinpschaaf

Labels
1.x-2.x compatibility 2.x p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dfreedm @kevinpschaaf @valdrinkoshi