2.0 preview #64

valdrinkoshi · 2016-09-16T00:04:04Z

I adapted it to work both in 1.0 and 2.0.

googlebot · 2017-01-12T05:03:59Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

googlebot · 2017-02-07T00:35:06Z

CLAs look good, thanks!

bicknellr · 2017-03-30T18:54:05Z

The demo seems broken: nothing happens when I click on any of the buttons or the boxes labelled 'target'.

bicknellr · 2017-04-05T00:10:33Z

demo/index.html

@@ -96,7 +94,7 @@
        </simple-fit>
        <script>
          var defaultTarget = Polymer.dom(myFit).parentNode;
-          var template = document.querySelector('template[is="dom-bind"]');
+          var template = document.querySelector('dom-bind');


Does this work in 1.x?

valdrinkoshi · 2017-04-06T21:25:48Z

@bicknellr re nothing happening on click => Polymer/polymer#4509

googlebot · 2017-04-07T00:37:07Z

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

bicknellr · 2017-04-10T21:13:28Z

demo/index.html

        button.selected {
          background-color: #b3e5fc;
        }
      </style>
-      <template is="dom-bind">
+      <dom-bind><template is="dom-bind">
        <template is="dom-repeat" items="[[containers]]">


Does this dom-repeat require a wrapper? I know that you don't need them within a dom-module's template but I can't remember if they're necessary in another dom-*'s template like this one.

Well, the demo's working so this one must not require a wrapper.

Yup, Kevin says that template extensions don't need wrappers if they're nested in a template that's being managed by Polymer in some way (i.e. the template for a dom-module or anywhere in the dom-* elements`).

bicknellr · 2017-04-11T18:11:14Z

iron-fit-behavior.html

-          setTimeout(function() {
+        // If invisible or in a shadow root that's still not connected, wait a tick.
+        if (window.getComputedStyle(this).display === 'none' ||
+          document.body.contains(this) === false) {


document.body.contains(this) will only be true when this isn't inside any ShadowRoot, even if its connected. Are you finding that attached is getting fired when this isn't connected? If so, this could be another reactions queue issue.

I saw that the element wasn't centered correctly on firefox. After debugging i realized that it had all 0s in its getClientBoundingRect on attached. I should debug this more and discover where's the issue exactly - I was under the impression that attached would be called in cases like this

var ce = document.createElement('custom-element'); document.createElement('div').appendChild(ce); // div not in body, though custom-element is attached!

attached only called in gets called as a result of connectedCallback (I don't think there are other places?) and connectedCallback reactions are only enqueued when an element's shadow-including root changes from a non-document to a document. So, running that snippet on its own won't cause ce'sattached to run. However, if attached is getting called as a result of that snippet, then this is likely a bug in the custom elements polyfill.

Oh I see. I'll write a small repro & file a bug then 👌

This is a different behavior compared to 1.x - awaiting news on webcomponents/shadydom#120

updated to flush in b6f5441

bicknellr · 2017-04-13T23:45:02Z

iron-fit-behavior.html

            this.fit();
          }.bind(this));
        } else {
+          // NOTE: shadydom won't apply the upgrades synchronously for performance reasons


(same comment as this one in paper-ripple, this is problem is about distribution rather than upgrades)

bicknellr

The default positionTarget used by the IronFitBehavior element in the demo is different in 1.x vs 2.x because dom-bind seems to be putting things inside it next to the template in 1.x and outside itself in 2.x. This makes the demo seem really broken, particularly in 1.x since the dom-bind ends up with display: inline; (the default for unknown elements). I'll confirm with Kevin, but this should probably be considered a dom-bind bug. If not, the demo needs to be restructured to make this look consistent.

valdrinkoshi · 2017-04-14T21:53:49Z

Wow good catch! 💯 Yeah it looks like a dom-bind bug...please update this PR with the issue! In case that's a "wontfix" from dom-bind, it would be still useful to have a pointer to that in a comment 👌

bicknellr · 2017-04-15T00:31:31Z

Filed as Polymer/polymer#4536; sounds like they're planning on fixing this today.

bicknellr · 2017-04-17T23:58:41Z

^ Update on this bug: merged, so should be in v1.9.1.

bicknellr · 2017-04-18T00:02:21Z

... and we're tagged. I'll give the demos another quick check.

bicknellr

Ok, demo looks good with Polymer v1.9.1!

googlebot · 2017-05-12T19:51:56Z

CLAs look good, thanks!

googlebot added the cla: yes label Sep 16, 2016

valdrinkoshi force-pushed the 2.0-preview branch from b0e0818 to e02513f Compare December 1, 2016 22:49

googlebot added cla: no and removed cla: yes labels Jan 12, 2017

valdrinkoshi force-pushed the 2.0-preview branch from 8f6398f to d093013 Compare February 7, 2017 00:35

googlebot added cla: yes and removed cla: no labels Feb 7, 2017

valdrinkoshi force-pushed the 2.0-preview branch from 53a0b1e to 36a7f23 Compare February 23, 2017 23:20

bicknellr reviewed Apr 5, 2017

View reviewed changes

googlebot added cla: no and removed cla: yes labels Apr 7, 2017

bicknellr reviewed Apr 10, 2017

View reviewed changes

bicknellr reviewed Apr 11, 2017

View reviewed changes

bicknellr mentioned this pull request Apr 12, 2017

2.0 preview PolymerElements/paper-ripple#91

Merged

bicknellr reviewed Apr 14, 2017

View reviewed changes

bicknellr approved these changes Apr 18, 2017

View reviewed changes

valdrinkoshi force-pushed the 2.0-preview branch from a46abeb to bc7b0c5 Compare May 12, 2017 19:30

valdrinkoshi added 3 commits May 12, 2017 12:43

port to 2.0

bdf3c06

use demo-pages-shared-styles (reverted)

fe97120

custom-elements-v1

7eb786e

valdrinkoshi and others added 24 commits May 12, 2017 12:43

use new custom-style syntax

af5bdc9

use dom-bind and dom-repeat

f9fbeb6

update deps

bcb844e

resolve webcomponents v1, remove <content>

0d00d54

variants

a4959ac

script inside dom-module, remove <content>

784ce23

use wc-ce flag instead of wc-register

b83af61

update deps and resolutions

df7ebf9

Depend on test-fixture v2

b4051d5

auto-generated: update repo for v2

e033ec7

remove duplicate scripts

550b57c

fix safari9 tests

9fe3865

update deps

aa839d9

Point to Polymer 2.0 RC 1

26cd438

address feedback

57b155a

remove test-fixture dependency

2ffd97d

Fix demo for tap not being fired. Defer refit.

d02accd

revert comment indentation

ab5d81b

Update travis config

4f5ce28

flush and explain why

f0cc90b

remove workaround for Polymer/polymer#4509. Clearer comment of why flush

f01313a

[skip ci] update README

908f24a

Update travis config

d0e1543

fix rebase errors

db3cbf5

valdrinkoshi force-pushed the 2.0-preview branch from bc7b0c5 to db3cbf5 Compare May 12, 2017 19:51

googlebot added cla: yes and removed cla: no labels May 12, 2017

valdrinkoshi merged commit 06f7844 into master May 12, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

2.0 preview #64

2.0 preview #64

valdrinkoshi commented Sep 16, 2016 •

edited

Loading

googlebot commented Jan 12, 2017

googlebot commented Feb 7, 2017

bicknellr commented Mar 30, 2017

bicknellr Apr 5, 2017

valdrinkoshi commented Apr 6, 2017

googlebot commented Apr 7, 2017

bicknellr Apr 10, 2017

bicknellr Apr 10, 2017

bicknellr Apr 10, 2017

bicknellr Apr 11, 2017

valdrinkoshi Apr 11, 2017

bicknellr Apr 11, 2017

valdrinkoshi Apr 11, 2017

valdrinkoshi Apr 12, 2017

valdrinkoshi Apr 13, 2017

bicknellr Apr 13, 2017

valdrinkoshi Apr 14, 2017

bicknellr left a comment

valdrinkoshi commented Apr 14, 2017

bicknellr commented Apr 15, 2017

bicknellr commented Apr 17, 2017 •

edited

Loading

bicknellr commented Apr 18, 2017

bicknellr left a comment

googlebot commented May 12, 2017

2.0 preview #64

2.0 preview #64

Conversation

valdrinkoshi commented Sep 16, 2016 • edited Loading

googlebot commented Jan 12, 2017

googlebot commented Feb 7, 2017

bicknellr commented Mar 30, 2017

Choose a reason for hiding this comment

valdrinkoshi commented Apr 6, 2017

googlebot commented Apr 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bicknellr left a comment

Choose a reason for hiding this comment

valdrinkoshi commented Apr 14, 2017

bicknellr commented Apr 15, 2017

bicknellr commented Apr 17, 2017 • edited Loading

bicknellr commented Apr 18, 2017

bicknellr left a comment

Choose a reason for hiding this comment

googlebot commented May 12, 2017

valdrinkoshi commented Sep 16, 2016 •

edited

Loading

bicknellr commented Apr 17, 2017 •

edited

Loading