Merge pull request #4530 from Polymer/4509-kschaaf-dom-bind-gestures

Add GestureEventListeners to dom-bind. Fixes #4509
Polymer · Apr 13, 2017 · 7da6ff4 · 7da6ff4
2 parents 93e436f + 6e4b87c
commit 7da6ff4
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 12 deletions.
diff --git a/lib/elements/dom-bind.html b/lib/elements/dom-bind.html
@@ -11,13 +11,17 @@
 <link rel="import" href="../utils/boot.html">
 <link rel="import" href="../mixins/property-effects.html">
 <link rel="import" href="../mixins/mutable-data.html">
+<link rel="import" href="../mixins/gesture-event-listeners.html">
 
 <script>
 
   (function() {
     'use strict';
 
-    const domBindBase = Polymer.OptionalMutableData(Polymer.PropertyEffects(HTMLElement));
+    const domBindBase =
+      Polymer.GestureEventListeners(
+        Polymer.OptionalMutableData(
+          Polymer.PropertyEffects(HTMLElement)));
 
     /**
      * Custom element to allow using Polymer's template features (data binding,

diff --git a/test/unit/dom-bind.html b/test/unit/dom-bind.html
@@ -32,7 +32,7 @@
 
   <dom-bind id="declarativeDomBind">
     <template>
-      <x-basic id="declaredXBasic1" value="{{value}}" notifyingvalue="{{nvalue}}" on-custom="handleEvent" computed="{{compute(dep)}}"></x-basic>
+      <x-basic id="declaredXBasic1" value="{{value}}" notifyingvalue="{{nvalue}}" on-custom="handleEvent" on-tap="handleTap" computed="{{compute(dep)}}"></x-basic>
       <x-basic id="declaredXBasic2" value="{{value}}" notifyingvalue="{{nvalue}}"></x-basic>
       <x-produce-a bind-to-text={{boundText}}></x-produce-a>
       <div id="boundTextDiv">{{boundText}}</div>
@@ -89,12 +89,15 @@
       });
 
       test('event listener fires', function() {
-        var count = 0;
-        domBind.handleEvent = function() {
-          count++;
-        };
+        domBind.handleEvent = sinon.spy();
         el1.fire('custom');
-        assert.equal(count, 1);
+        assert.equal(domBind.handleEvent.callCount, 1);
+      });
+
+      test('gesture event listener fires', function() {
+        domBind.handleTap = sinon.spy();
+        el1.click();
+        assert.equal(domBind.handleTap.callCount, 1);
       });
 
       test('inline function runs', function() {
@@ -130,6 +133,7 @@
         el1.setAttribute('value', '{{value}}');
         el1.setAttribute('notifyingvalue', '{{nvalue}}');
         el1.setAttribute('on-custom', 'handleEvent');
+        el1.setAttribute('on-tap', 'handleTap');
         el1.setAttribute('computed', '{{compute(dep)}}');
 
         el2 = doc.createElement('x-basic');
@@ -165,12 +169,15 @@
       });
 
       test('event listener fires', function() {
-        var count = 0;
-        domBind.handleEvent = function() {
-          count++;
-        };
+        domBind.handleEvent = sinon.spy();
         el1.fire('custom');
-        assert.equal(count, 1);
+        assert.equal(domBind.handleEvent.callCount, 1);
+      });
+
+      test('gesture event listener fires', function() {
+        domBind.handleTap = sinon.spy();
+        el1.click();
+        assert.equal(domBind.handleTap.callCount, 1);
       });
 
       test('inline function runs', function() {