-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Components - fillout #12690
New Components - fillout #12690
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughThe changes enhance the Changes
Sequence Diagram(s)sequenceDiagram
participant Developer
participant FilloutApp
participant FilloutAPI
Developer->>FilloutApp: Request to fetch forms
FilloutApp->>FilloutAPI: API call to fetch forms
FilloutAPI-->>FilloutApp: Response with forms list
FilloutApp-->>Developer: Return forms list
Developer->>FilloutApp: Create webhook for form submission
FilloutApp->>FilloutAPI: API call to create webhook
FilloutAPI-->>FilloutApp: Response with webhook details
FilloutApp-->>Developer: Webhook created confirmation
FilloutAPI->>FilloutApp: Webhook triggered on form submission
FilloutApp->>FilloutAPI: Get submission details
FilloutAPI-->>FilloutApp: Submission details response
FilloutApp-->>Developer: Emit new submission event
Assessment against linked issues
Poem
Tip AI model upgrade
|
Sources - New Submission (Instant)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
Files selected for processing (4)
- components/fillout/fillout.app.mjs (1 hunks)
- components/fillout/package.json (2 hunks)
- components/fillout/sources/new-submission-instant/new-submission-instant.mjs (1 hunks)
- components/fillout/sources/new-submission-instant/test-event.mjs (1 hunks)
Additional comments not posted (13)
components/fillout/package.json (1)
3-3
: Version update and new dependency addition are appropriate.The version update follows semantic versioning, and the new dependency is necessary for the new functionality.
Also applies to: 15-18
components/fillout/fillout.app.mjs (7)
1-2
: Import statement is correct.The import statement for axios from @pipedream/platform is necessary for making HTTP requests.
6-19
: Dynamic formId options fetching is well-implemented.The async options method for the formId property ensures dynamic fetching of form options.
21-23
: Base URL method is correctly defined.The _baseUrl method provides the correct base URL for the Fillout API.
24-28
: Authorization headers method is correctly defined.The _headers method constructs the necessary authorization headers using the OAuth access token.
29-37
: Unified request handling method is well-implemented.The _makeRequest method encapsulates the axios call, ensuring consistent request handling.
38-42
: getForms method is correctly implemented.The getForms method uses _makeRequest to fetch the list of forms from the API.
43-55
: Webhook management methods are correctly implemented.The createWebhook and deleteWebhook methods use _makeRequest to manage webhooks via the API.
components/fillout/sources/new-submission-instant/new-submission-instant.mjs (4)
1-2
: Import statements are correct.The import statements for fillout app and sampleEmit are necessary for the component functionality.
4-24
: Component properties are correctly defined.The component properties include Fillout app, HTTP interface, database service, and formId prop definition.
25-44
: Webhook lifecycle management is correctly implemented.The activate and deactivate hooks manage the webhook lifecycle by creating and deleting webhooks via the Fillout API.
46-52
: Event emission method is correctly implemented.The run method emits events with the correct structure when a new form submission is received.
components/fillout/sources/new-submission-instant/test-event.mjs (1)
1-69
: Test event data is comprehensive and well-structured.The test event object includes detailed form, submission, and associated data, providing a thorough representation for testing purposes.
Resolves #12553.
Summary by CodeRabbit
New Features
Improvements
Dependencies
@pipedream/platform
dependency.