-
Notifications
You must be signed in to change notification settings - Fork 254
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to select from registry list if name is undefined #188
Conversation
|
@iosh I had completed the feature. But I am good at writing test cases. Can you help me? |
Do you mean that you're not good at writing tests? If so, I can help you. but I will need some time to do this. |
Yes. I try to add test case. But I failed...... |
I forget to ask how to update readme. It is necessary to add |
@chouchouji Node 16 is end of life, So i will update the node version in CI to 18(this weekend). |
ok |
sorry, I clicked close. Can you reopen it. Thanks! |
Is it enough to just modify the node version in ci? If it is, I am pleased to submit a pr. |
Sorry, I can't reopen this PR as the button is disabled and it says "The feat-use branch was force-pushed or recreated." I think you might need to create a new PR.
I think so, we can try for this. |
The new pr is #191. Thanks. |
Issue
close #187
Result
use.mp4