Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to select from registry list if name is undefined #188

Closed
wants to merge 2 commits into from

Conversation

chouchouji
Copy link
Contributor

@chouchouji chouchouji commented Nov 19, 2024

Issue

close #187

Result

use.mp4

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 148216e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chouchouji
Copy link
Contributor Author

chouchouji commented Nov 19, 2024

@iosh I had completed the feature. But I am good at writing test cases. Can you help me?

@iosh
Copy link
Collaborator

iosh commented Nov 20, 2024

@iosh I had completed the feature. But I am good at writing test cases. Can you help me?

Do you mean that you're not good at writing tests? If so, I can help you. but I will need some time to do this.

@chouchouji
Copy link
Contributor Author

@iosh I had completed the feature. But I am good at writing test cases. Can you help me?

Do you mean that you're not good at writing tests? If so, I can help you. but I will need some time to do this.

Yes. I try to add test case. But I failed......

@chouchouji
Copy link
Contributor Author

I forget to ask how to update readme. It is necessary to add nrm use tip for users.

@iosh
Copy link
Collaborator

iosh commented Nov 21, 2024

@chouchouji Node 16 is end of life, So i will update the node version in CI to 18(this weekend).

@chouchouji
Copy link
Contributor Author

@chouchouji Node 16 is end of life, So i will update the node version in CI to 18(this weekend).

ok

@chouchouji chouchouji closed this Nov 21, 2024
@chouchouji
Copy link
Contributor Author

sorry, I clicked close. Can you reopen it. Thanks!

@chouchouji
Copy link
Contributor Author

@chouchouji Node 16 is end of life, So i will update the node version in CI to 18(this weekend).

Is it enough to just modify the node version in ci? If it is, I am pleased to submit a pr.

@iosh
Copy link
Collaborator

iosh commented Nov 21, 2024

sorry, I clicked close. Can you reopen it. Thanks!

Sorry, I can't reopen this PR as the button is disabled and it says "The feat-use branch was force-pushed or recreated." I think you might need to create a new PR.

@chouchouji Node 16 is end of life, So i will update the node version in CI to 18(this weekend).

Is it enough to just modify the node version in ci? If it is, I am pleased to submit a pr.

I think so, we can try for this.

@chouchouji
Copy link
Contributor Author

sorry, I clicked close. Can you reopen it. Thanks!

Sorry, I can't reopen this PR as the button is disabled and it says "The feat-use branch was force-pushed or recreated." I think you might need to create a new PR.

@chouchouji Node 16 is end of life, So i will update the node version in CI to 18(this weekend).

Is it enough to just modify the node version in ci? If it is, I am pleased to submit a pr.

I think so, we can try for this.

The new pr is #191. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] nrm use supports select
2 participants