Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Style] How to format code #189

Closed
chouchouji opened this issue Nov 19, 2024 · 4 comments · Fixed by #190
Closed

[Style] How to format code #189

chouchouji opened this issue Nov 19, 2024 · 4 comments · Fixed by #190

Comments

@chouchouji
Copy link
Contributor

Question

I found that I can't format code when I am working for #188. I try to format code(my default formatter is prettier), one of the results is that single quotes are turned into double quotes. So, I want to know the way of formating code. Thanks !

Link

link.mp4
@iosh
Copy link
Collaborator

iosh commented Nov 20, 2024

I thinks this project is lack configuration for code format, I suggest that #188 only format the modified code, and then we can ad a format configuration for the project ,and format all code.

@chouchouji
Copy link
Contributor Author

I thinks this project is lack configuration for code format, I suggest that #188 only format the modified code, and then we can ad a format configuration for the project ,and format all code.

Thanks for your reply. I only format the modified code like other for that pr. What format configuration do you want to add? Prettier?

@iosh
Copy link
Collaborator

iosh commented Nov 20, 2024

Prettier is OK, Do you want PR for this ?

@chouchouji
Copy link
Contributor Author

Prettier is OK, Do you want PR for this ?

Yes, I will submit a pr today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants