Refactor audio message to Dialogue Utterance #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix build script to *actually* pass forward extra args to docker compose build command.
derkmed
force-pushed
the
dialogue_utterance
branch
from
834a8aa
to
ea4224c
Compare
derkmed
force-pushed
the
dialogue_utterance
branch
from
61bb218
to
7b3409f
Compare
|
@Purg @hdefazio @joshanderson-kw This should be in a reviewable state. It refactors all nodes to use a new general purpose message that allows on-the-fly re-ordering or removal of audio nodes depending on compute-latency constraints. The next PRs will attempt to bring ASR + VAD locally, add visual question answering, and add @ovenmitt 's demo changes. |
|
@derkmed can you rebase on the latest master? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first of several mini-PRs that will cover the changes proposed in #378
We should remove the previously used messages upon confirmation of working implementation.