Drop Php7.4 Support #3710
Closed
Drop Php7.4 Support #3710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix PHPOffice#3634. Its time has come. Based on our experience dropping 7.3, I anticipate problems with Github Actions.
Probably need to do this is 2 steps. First to make 7.4, which is required, experimental. Then, once that's installed, do the final remove for 7.4.
Latest problem did not occur for 7.3. Let's see what's needed.
|
oh, you just beat me to it. I was about to submit a PR for that. If you don't mind I'd like to try anyway, my intent is to be a be more aggressive than the commits here and also drop all the special cases that exists to support PHP 7.4. Would that be OK with you ? |
|
@PowerKiKi Perfect. I will close this ticket and let you proceed. |
PowerKiKi
added a commit
that referenced
this pull request
Sep 6, 2023
This is according to our formal, published, policy to only support EOL PHP after 6 months. See https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support Also share the exact same dev deps across all PHP version for GitHub Actions so runs are faster, much most importantly they are stable and predictable. And we decide manually when we want to migrate to PHPUnit 10. Fixes #3634 Closes #3710
PowerKiKi
added a commit
that referenced
this pull request
Sep 6, 2023
This is according to our formal, published, policy to only support EOL PHP after 6 months. See https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support Also share the exact same dev deps across all PHP version for GitHub Actions so runs are faster, much most importantly they are stable and predictable. And we decide manually when we want to migrate to PHPUnit 10. Fixes #3634 Closes #3710
PowerKiKi
added a commit
that referenced
this pull request
Sep 6, 2023
This is according to our formal, published, policy to only support EOL PHP after 6 months. See https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support Also share the exact same dev deps across all PHP version for GitHub Actions so runs are faster, much most importantly they are stable and predictable. And we decide manually when we want to migrate to PHPUnit 10. Fixes #3634 Closes #3710
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3634. Its time has come. Based on our experience dropping 7.3, I anticipate problems with Github Actions. No code changes.
This is:
Checklist:
Why this change is needed?
Provide an explanation of why this change is needed, with links to any Issues (if appropriate).
If this is a bugfix or a new feature, and there are no existing Issues, then please also create an issue that will make it easier to track progress with this PR.