Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Php7.4 Support #3710

Closed
wants to merge 4 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/github-pages.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ jobs:
- name: Setup PHP, with composer and extensions
uses: shivammathur/setup-php@v2
with:
php-version: 7.4
php-version: 8.1
coverage: none # remove xdebug

- name: Build API documentation
Expand Down
8 changes: 5 additions & 3 deletions .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,15 @@ jobs:
experimental:
- false
php-version:
- '7.4'
- '8.0'
- '8.1'
- '8.2'

include:
- php-version: 'nightly'
experimental: true
- php-version: '7.4'
experimental: true

name: PHP ${{ matrix.php-version }}

Expand Down Expand Up @@ -49,6 +50,7 @@ jobs:
echo "flags=--ignore-platform-reqs" >> $GITHUB_OUTPUT

- name: Install dependencies
if: ${{ matrix.php-version != '7.4' }}
run: composer update --no-progress --prefer-dist --optimize-autoloader ${{ steps.composer-lock.outputs.flags }}

- name: Setup problem matchers for PHP
Expand All @@ -60,7 +62,7 @@ jobs:
- name: "Run PHPUnit tests 1 (Experimental: ${{ matrix.experimental }})"
env:
FAILURE_ACTION: "${{ matrix.experimental == true }}"
if: ${{ matrix.php-version == '7.4' || matrix.php-version == '8.0' }}
if: ${{ matrix.php-version == '8.0' }}
run: vendor/bin/phpunit --verbose || $FAILURE_ACTION

- name: "Run PHPUnit tests 2 (Experimental: ${{ matrix.experimental }})"
Expand Down Expand Up @@ -160,7 +162,7 @@ jobs:
run: composer install --no-progress --prefer-dist --optimize-autoloader

- name: Code Version Compatibility check with PHP_CodeSniffer
run: ./vendor/bin/phpcs -q --report-width=200 --report=summary,full src/ --standard=PHPCompatibility --runtime-set testVersion 7.4-
run: ./vendor/bin/phpcs -q --report-width=200 --report=summary,full src/ --standard=PHPCompatibility --runtime-set testVersion 8.0-

phpstan:
runs-on: ubuntu-latest
Expand Down
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"scripts": {
"check": [
"phpcs src/ tests/ --report=checkstyle",
"phpcs --report-width=200 samples/ src/ tests/ --ignore=samples/Header.php --standard=PHPCompatibility --runtime-set testVersion 7.4- -n",
"phpcs --report-width=200 samples/ src/ tests/ --ignore=samples/Header.php --standard=PHPCompatibility --runtime-set testVersion 8.0- -n",
"php-cs-fixer fix --ansi --dry-run --diff",
"phpunit --color=always",
"phpstan analyse --ansi --memory-limit=2048M"
Expand All @@ -57,11 +57,11 @@
"php-cs-fixer fix"
],
"versions": [
"phpcs --report-width=200 samples/ src/ tests/ --ignore=samples/Header.php --standard=PHPCompatibility --runtime-set testVersion 7.4- -n"
"phpcs --report-width=200 samples/ src/ tests/ --ignore=samples/Header.php --standard=PHPCompatibility --runtime-set testVersion 8.0- -n"
]
},
"require": {
"php": "^7.4 || ^8.0",
"php": "^8.0",
"ext-ctype": "*",
"ext-dom": "*",
"ext-fileinfo": "*",
Expand Down