Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for PHP 7.4 #3634

Closed
1 of 3 tasks
garak opened this issue Jul 3, 2023 · 4 comments
Closed
1 of 3 tasks

Drop support for PHP 7.4 #3634

garak opened this issue Jul 3, 2023 · 4 comments

Comments

@garak
Copy link

garak commented Jul 3, 2023

This is:

As stated in the README, this project supports PHP 7.4 until 28th June 2023.
So, the minimum supported PHP version should be raised to 8.0
@MarkBaker
Copy link
Member

And it will be.
The LTS doesn't necessarily mean that we do it immediately on the date, just that the next release after that date will no longer support the dropped version.

@garak
Copy link
Author

garak commented Jul 3, 2023

I see.
So I guess you can keep this issue open as a reminder.

@mhcwebdesign
Copy link

And it will be. The LTS doesn't necessarily mean that we do it immediately on the date, just that the next release after that date will no longer support the dropped version.

And that case, can you please re-add support for PHP 8.0 (see #3684)? It used to support PHP 8.0 in previous releases just fine, e.g. 1.25.2 . Or update the docs.

Anyway, thanks for all the hard work that has gone into the PhpSpreadsheet project, it is very useful.

@oleibman
Copy link
Collaborator

Php 8.0 is fully supported. For the issue to which you link, it seems you are running Php8.0 with Zipstream v3, which does not support 8.0; however, PhpSpreadsheet supports Zipstream V2 and V3. See #3615 (comment) for a means to clear your problem.

oleibman added a commit to oleibman/PhpSpreadsheet that referenced this issue Sep 6, 2023
@oleibman
Drop Php7.4 Support
85bec74 
Fix PHPOffice#3634. Its time has come. Based on our experience dropping 7.3, I anticipate problems with Github Actions.
@oleibman oleibman mentioned this issue Sep 6, 2023
Closed
11 tasks
PowerKiKi added a commit that referenced this issue Sep 6, 2023
@PowerKiKi
Drop PHP 7.4 support
972a1cd 
This is according to our formal, published, policy to only support
EOL PHP after 6 months.

See https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support

Also share the exact same dev deps across all PHP version for GitHub
Actions so runs are faster, much most importantly they are stable and
predictable. And we decide manually when we want to migrate to PHPUnit
10.

Fixes #3634
Closes #3710
PowerKiKi added a commit that referenced this issue Sep 6, 2023
@PowerKiKi
Drop PHP 7.4 support
93509c2 
This is according to our formal, published, policy to only support
EOL PHP after 6 months.

See https://phpspreadsheet.readthedocs.io/en/latest/#php-version-support

Also share the exact same dev deps across all PHP version for GitHub
Actions so runs are faster, much most importantly they are stable and
predictable. And we decide manually when we want to migrate to PHPUnit
10.

Fixes #3634
Closes #3710
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Drop Php7.4 Support oleibman/PhpSpreadsheet
4 participants
@garak @MarkBaker @mhcwebdesign @oleibman