Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop Elevation Z-Index Tokens #109

Closed
julien-deramond opened this issue Sep 19, 2024 · 1 comment · Fixed by #110
Closed

Drop Elevation Z-Index Tokens #109

julien-deramond opened this issue Sep 19, 2024 · 1 comment · Fixed by #110
Assignees
@pylapp
Labels
🗳️ feature Related to features 🧬 token Related to tokens (raws, semantics or components)

Comments

@julien-deramond
Copy link
Contributor

Description

Elevation Z-Index tokens are not being used by designers and will not be generated during the Style Dictionary process. You can safely remove these tokens from your codebase, or relocate them if you believe they might still be useful. For example, in web development, these values can be valuable, but they are fixed within the framework rather than being managed through tokens.
@pylapp pylapp self-assigned this Sep 19, 2024
pylapp added a commit that referenced this issue Sep 19, 2024
@pylapp
refactor: remove elevationZIndex tokens
ed0b949 
Closes #109

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp mentioned this issue Sep 19, 2024
Merged
9 tasks
@pylapp pylapp linked a pull request Sep 19, 2024 that will close this issue
[#109] Drop elevation z index tokens #110
Merged
9 tasks
pylapp added a commit that referenced this issue Sep 19, 2024
@pylapp
refactor: remove elevationZIndex tokens (#109)
ee80af3 
Closes #109

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp
Copy link
Member

pylapp commented Sep 19, 2024

📣 New TestFlight ALPHA uploap available 🚀

Please, get the new build from TestFlight app.

  • Display name: OUDS Showcase ALPHA (109)
  • Version: 0.2.0
  • Build number: 1726743140
  • Build tag: febe4a6
  • Build type: ALPHA
  • Build details (GitHub): 109

This is an automated message sent with love and Fastlane from our CI/CD pipeline 🤘

pylapp added a commit that referenced this issue Sep 19, 2024
@pylapp @ludovic35 @julien-deramond
Version 0.2.0 (#113)
98640b4 
Released of version 0.2.0
See below the full CHANGELOG details.

Added:
- [Tests] Add UI regression tests using snapshot comparisons with *swift-snapshot-testing* tool ([#78](#78))
- [DemoApp] Display fake components for elevation rendering tests
- [Library] A theme can now override the custom font family
- [Tests] Add more unit tests for theme overriding and raw tokens controls
- [Library] Add and update raw and semantic grid tokens ([#40](#40))
- [Library] Manage regular and compact layouts for sizing and spacing tokens
- [Library] "Box shadow 0" has been defined and "elevation drag" changed
- [Doc] Create the basics of a documentation ([#9](#9))
- [Library] Add more semanttic and raw tokens for typography
- [Library] Add more semantic and raw tokens for typography, and SwiftUI API to apply them
- [Library] Computation of SwiftUI radius from Figma blur and spread values for elevation tokens
- [Library] Add elevation tokens ([#32](#32))

Changed:
- [Library] Split raws, semantics and components tokens definitions and also values, composites and type aliases
- [Showcase] Improve Fastlane alpha build notifications
- [Library] Do not store blur value in elevation semantic tokens
- [Library] Change type aliases for X and Y offsets of elevations tokens
- [Library] Update border semantic tokens values ([#106](#106))
- [Showcase] Add fake components for demo and tokens tests
- [Library] Remove spread value for elevation tokens
- [Library] Remove paragraph spacing tokens for typography
- [Library] Term "fluid" has been replaced by "adaptable" in spacing semantic tokens
- [Doc] Improve DocC documentation about tokens and views extensions
- [Doc] Add more details in release documentation
- [Library] Rename semantic token "opacityEmphasized" to "opacityStrong" ([#94](#94))
- [Library] Update value of opacity raw token "opacity800" from 0.88 to 0.80 ([#87](#87))
- [Tests] Add missing unit tests for opacity raw tokens
- [Library] "OUDSThemesCommons" product has been renamed to "OUDS"

Removed:
- [Library] Remove Z Index tokens for elevations ([#109](#109))
- [Library] Remove token "borderRadiusPill" and "borderRadiusCircle" ([#58](#58))
- [Library] "Emphasis" words have been replaced by "emphasized"
- [Library] "Box shadow" words have been removed in elevation semantic and raw tokens 

Fixed:
- [Library] Fix some typos in documentation ([#89](#89))

Acked-by: Ludovic Pinel <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
@pylapp pylapp added 🧬 token Related to tokens (raws, semantics or components) 🗳️ feature Related to features labels Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
🗳️ feature Related to features 🧬 token Related to tokens (raws, semantics or components)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#109] Drop elevation z index tokens Orange-OpenSource/ouds-ios
2 participants
@pylapp @julien-deramond