Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#109] Drop elevation z index tokens #110

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

pylapp
Copy link
Member

@pylapp pylapp commented Sep 19, 2024

Note: Please transform - [ ] into - (NA) in the description when things are not applicable

Related issues

#109

Description

  • Drop Z Index tokens for elevations
  • Improve doc and tests

Motivation & Context

Types of change

  • Breaking change (fix or feature that would change existing functionality)

Previews

Checklist

Contribution

Accessibility

  • (NA) My change follows accessibility good practices

Design

  • (NA) My change respects the design guidelines of Orange Unified Design System

Development

  • My change follows the developer guide
  • I have added unit tests to cover my changes (optional)

Documentation

  • My change introduces changes to the documentation and/or I have updated the documentation accordingly

Checklist (for Core Team only)

  • The evolution have been tested and the project builds for iPhones and iPads
  • Code review has been done by reviewers according to CODEOWNERS file
  • (NA) Design review has been done
  • (NA) Accessibiltiy review has been done
  • (NA) Q/A team has tested the evolution
  • Documentation has been updated if relevant
  • Internal files have been updated if relevant (like CONTRIBUTING, DEVELOP, THIRD_PARTY, CONTRIBUTORS, NOTICE)
  • CHANGELOG has been updated respecting keep a changelog rules and reference the issues

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
Closes #109

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp self-assigned this Sep 19, 2024
@pylapp pylapp requested a review from ludovic35 as a code owner September 19, 2024 08:38
@pylapp pylapp linked an issue Sep 19, 2024 that may be closed by this pull request
@ludovic35 ludovic35 merged commit 5f5664c into develop Sep 19, 2024
3 of 4 checks passed
@ludovic35 ludovic35 deleted the 109-drop-elevation-z-index-tokens branch September 19, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Elevation Z-Index Tokens
2 participants