Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tokens: Remove border-radius-circle at 50% #58

Closed
pylapp opened this issue Aug 5, 2024 · 4 comments · Fixed by #81
Closed

Tokens: Remove border-radius-circle at 50% #58

pylapp opened this issue Aug 5, 2024 · 4 comments · Fixed by #81
Assignees
@pylapp
Labels
🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components)

Comments

@pylapp
Copy link
Member

pylapp commented Aug 5, 2024 •
edited
Loading

In addition to issue #30, some study should be done about what is exepeted for the semantic token "border-radius-circle" which has a value of "50%".
Indeed this case is particular because it does no match at all the other types of values any borrder radius semantic token have.
This case should be considered with design team.

EDIT: This token should be removed (refering this issue in CHANGELOG and Git history), and also the "pill" shape (token border-radius-9999 / 2000)

cc @julien-deramond @ludovic35
@pylapp pylapp added 🆕 feature Related to features 💥 blocking Issue can go further and is blocked by something labels Aug 5, 2024
@pylapp pylapp mentioned this issue Aug 30, 2024
Closed
1 task
@julien-deramond julien-deramond moved this to Triage in [OUDS] Project Sep 2, 2024
@pylapp
Copy link
Member Author

pylapp commented Sep 2, 2024

FYI After a meeting this token should be removed.
@julien-deramond You may want to recycle this issue for token deletion instead of create a new one :)

@pylapp pylapp changed the title Tokens: Border special case for radius Tokens: Remove border-radius-circle at 50% Sep 2, 2024
@pylapp pylapp self-assigned this Sep 2, 2024
@pylapp pylapp removed the 💥 blocking Issue can go further and is blocked by something label Sep 2, 2024
@julien-deramond
Copy link
Contributor

This token should be removed or not implemented, and border radius pill too.

@julien-deramond julien-deramond moved this from Triage to Todo in [OUDS] Project Sep 5, 2024
pylapp added a commit that referenced this issue Sep 6, 2024
@pylapp
refactor: remove border tokens radius circle and radius pill (#58)
bac8385 
Closes #58

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp linked a pull request Sep 6, 2024 that will close this issue
[#58] Remove border tokens radius circle and radius pill (#58) #81
Merged
9 tasks
@pylapp pylapp mentioned this issue Sep 6, 2024
Merged
9 tasks
pylapp added a commit that referenced this issue Sep 12, 2024
@pylapp
refactor: remove border tokens radius circle and radius pill (#58)
07068a7 
Closes #58

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
pylapp added a commit that referenced this issue Sep 12, 2024
@pylapp
refactor: remove border tokens radius circle and radius pill (#58)
9fe03b1 
Closes #58

Signed-off-by: Pierre-Yves Lapersonne <[email protected]>
@pylapp pylapp closed this as completed in 1bb54e4 Sep 12, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in [OUDS] Project Sep 12, 2024
@pylapp
Copy link
Member Author

pylapp commented Sep 18, 2024

📣 New TestFlight ALPHA upload 🚀

  • Display name: OUDS Showcase ALPHA (78, 40, 9, 32, 106, 94, 87, 58, 89)
  • Version: 0.2.0
  • Build number: 1726677063
  • Build tag: fcb55ec
  • Build type: ALPHA
  • Build details (GitHub):78, 40, 9, 32, 106, 94, 87, 58, 89

This is an automated message sent with Fastlane from our CI/CD pipeline 🤘

pylapp added a commit that referenced this issue Sep 19, 2024
@pylapp @ludovic35 @julien-deramond
Version 0.2.0 (#113)
98640b4 
Released of version 0.2.0
See below the full CHANGELOG details.

Added:
- [Tests] Add UI regression tests using snapshot comparisons with *swift-snapshot-testing* tool ([#78](#78))
- [DemoApp] Display fake components for elevation rendering tests
- [Library] A theme can now override the custom font family
- [Tests] Add more unit tests for theme overriding and raw tokens controls
- [Library] Add and update raw and semantic grid tokens ([#40](#40))
- [Library] Manage regular and compact layouts for sizing and spacing tokens
- [Library] "Box shadow 0" has been defined and "elevation drag" changed
- [Doc] Create the basics of a documentation ([#9](#9))
- [Library] Add more semanttic and raw tokens for typography
- [Library] Add more semantic and raw tokens for typography, and SwiftUI API to apply them
- [Library] Computation of SwiftUI radius from Figma blur and spread values for elevation tokens
- [Library] Add elevation tokens ([#32](#32))

Changed:
- [Library] Split raws, semantics and components tokens definitions and also values, composites and type aliases
- [Showcase] Improve Fastlane alpha build notifications
- [Library] Do not store blur value in elevation semantic tokens
- [Library] Change type aliases for X and Y offsets of elevations tokens
- [Library] Update border semantic tokens values ([#106](#106))
- [Showcase] Add fake components for demo and tokens tests
- [Library] Remove spread value for elevation tokens
- [Library] Remove paragraph spacing tokens for typography
- [Library] Term "fluid" has been replaced by "adaptable" in spacing semantic tokens
- [Doc] Improve DocC documentation about tokens and views extensions
- [Doc] Add more details in release documentation
- [Library] Rename semantic token "opacityEmphasized" to "opacityStrong" ([#94](#94))
- [Library] Update value of opacity raw token "opacity800" from 0.88 to 0.80 ([#87](#87))
- [Tests] Add missing unit tests for opacity raw tokens
- [Library] "OUDSThemesCommons" product has been renamed to "OUDS"

Removed:
- [Library] Remove Z Index tokens for elevations ([#109](#109))
- [Library] Remove token "borderRadiusPill" and "borderRadiusCircle" ([#58](#58))
- [Library] "Emphasis" words have been replaced by "emphasized"
- [Library] "Box shadow" words have been removed in elevation semantic and raw tokens 

Fixed:
- [Library] Fix some typos in documentation ([#89](#89))

Acked-by: Ludovic Pinel <[email protected]>
Co-authored-by: Ludovic Pinel <[email protected]>
Co-authored-by: Pierre-Yves Lapersonne <[email protected]>
Co-authored-by: Julien Déramond <[email protected]>
@pylapp
Copy link
Member Author

pylapp commented Sep 19, 2024

ℹ️ FYI available since version v0.2.0. Go to the discussion for more details 🚀

@pylapp pylapp added the 📀 token Related to tokens (raws, semantics or components) label Sep 23, 2024
@pylapp pylapp mentioned this issue Oct 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pylapp pylapp

Labels
🆕 feature Related to features 📀 token Related to tokens (raws, semantics or components)
Projects
[OUDS] Project
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#58] Remove border tokens radius circle and radius pill (#58) Orange-OpenSource/ouds-ios
2 participants
@pylapp @julien-deramond