Skip to content

chore(monorepo): bump electron-builder to 26.0.15 #18445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mjhuff merged 3 commits into from
May 29, 2025
Merged

chore(monorepo): bump electron-builder to 26.0.15 #18445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
12b9197
chore(monorepo): bump electron-builder to 26.0.15
mjhuff May 28, 2025
146bf9d
Merge branch 'edge' into mono_bump-electron-builder
mjhuff May 28, 2025
d33eadd
Merge branch 'edge' into mono_bump-electron-builder
y3rsh May 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions app-shell/electron-builder.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,14 @@
},
win: {
target: ['nsis'],
publisherName: 'Opentrons Labworks Inc.',
icon: project === 'robot-stack' ? 'build/icon.ico' : 'build/three.ico',
forceCodeSigning: WINDOWS_SIGN,
rfc3161TimeStampServer: 'http://timestamp.digicert.com',
sign: 'scripts/windows-custom-sign.js',
signDlls: true,
signingHashAlgorithms: ['sha256'],
signtoolOptions: {
publisherName: 'Opentrons Labworks Inc.',
rfc3161TimeStampServer: 'http://timestamp.digicert.com',
sign: 'scripts/windows-custom-sign.js',
signingHashAlgorithms: ['sha256'],
},

Check warning on line 75 in app-shell/electron-builder.config.js

View check run for this annotation

Codecov / codecov/patch

app-shell/electron-builder.config.js#L70-L75 

Added lines #L70 - L75 were not covered by tests
},
nsis: {
oneClick: false,
Expand Down
5 changes: 4 additions & 1 deletion app-shell/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,9 @@
},
"homepage": "https://github.com/Opentrons/opentrons",
"workspaces": {
"nohoist": ["**"]
"nohoist": [
"**"
]
},
"devDependencies": {
"electron-notarize": "^1.2.1",
Expand All @@ -41,6 +43,7 @@
"@types/lodash": "^4.14.191",
"@types/pump": "^1.1.0",
"@types/uuid": "^3.4.7",
"agent-base": "6.0.2",
"ajv": "6.12.3",
"axios": "^0.21.1",
"dateformat": "3.0.3",
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@
"decompress": "4.2.1",
"download": "8.0.0",
"electron": "33.2.1",
"electron-builder": "25.1.8",
"electron-builder": "26.0.15",
"eslint": "^8.56.0",
"eslint-config-prettier": "^8.1.0",
"eslint-config-standard": "^16.0.2",
Expand Down
Loading
Loading